07-29-refactor_semantic_use_is_empty_instead_of_len_0_ - Branch - oxc-project/oxc

refactor(semantic): use `is_empty()` instead of `len() == 0`

#4532Merged

Comparing

07-29-refactor_semantic_use_is_empty_instead_of_len_0_

(

7b5e1f5

) with

main

(

148bdb5

)

Untouched: 32

Benchmarks

Passed

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

224.4 µs223.3 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.7 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.4 ms126.2 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

75.9 ms75.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.5 µs76.5 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75 ms75 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.6 ms37.6 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

62.5 ms62.4 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

244.1 ms244.1 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

138.7 ms138.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

378.2 ms378.1 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.3 ms18.3 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.6 µs22.6 µs

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.3 ms103.3 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

32.1 ms32.1 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

17.6 ms17.6 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 ms20 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.3 ms52.3 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

233 µs233.1 µs

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

283.9 ms284 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

516.5 ms516.8 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.2 ms3.2 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

74.4 ms74.5 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

46.3 ms46.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

806.4 ms809.2 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

1.4 s1.4 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

99.8 µs100.7 µs

Commits

Click on a commit to change the comparison range

Base

main

148bdb5

-0.04%

refactor(semantic): use `is_empty()` instead of `len() == 0` (#4532) It's preferred to use `is_empty` where possible. `is_empty` is sometimes slightly more optimized than `len() == 0`.

7b5e1f5

1 year ago

by overlookmotel

Home Terms Privacy Docs