07-29-fix_linter_fix_oxlint_allocator_cfg - Branch - oxc-project/oxc

fix(linter): fix `oxlint` allocator cfg

#4527Merged

Comparing

07-29-fix_linter_fix_oxlint_allocator_cfg

(

732f4e2

) with

main

(

d5c4b19

)

Untouched: 32

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

47.2 ms46.4 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

3.2 ms3.2 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

20.7 ms20.6 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

223.5 µs222.9 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.4 µs100.3 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

62.5 ms62.4 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75 ms75 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

75.9 ms75.9 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

283.8 ms283.7 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.5 µs76.5 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

126.3 ms126.3 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

32.1 ms32.1 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

17.6 ms17.6 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

244.1 ms244.1 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

516.2 ms516.2 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.3 ms18.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.3 ms52.3 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.3 ms103.3 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20 ms20 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

138.7 ms138.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

377.9 ms378 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

4.9 ms4.9 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

232.4 µs232.5 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

74.4 ms74.5 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

37.6 ms37.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.6 µs22.6 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

810.9 ms814.4 ms

Commits

Click on a commit to change the comparison range

Base

main

d5c4b19

+0.1%

fix(linter): fix `oxlint` allocator cfg (#4527) Fix 2 mistakes in the `#[cfg]` for custom allocators in `oxlint` CLI. 1. `#![cfg(not(miri))]` at top of file was disabling the entire module if running miri, rather than just disabling custom allocator. 2. If both `target_os = "windows"` and `not(target_env = "msvc")`, it would try to register both mimalloc and jemalloc as global allocator. I am actually not sure if it's possible to compile for Windows without using MSVC, but it seems like a good idea not to assume.

732f4e2

1 year ago

by overlookmotel

Home Terms Privacy Docs