07-25-refactor_syntax_use_nonmaxu32_for_ids - Branch - oxc-project/oxc

refactor(syntax): use `NonMaxU32` for IDs

#4467Merged

Comparing

07-25-refactor_syntax_use_nonmaxu32_for_ids

(

96fc94f

) with

main

(

a49f491

)

Untouched: 32

Benchmarks

Passed

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

772.1 ms763.7 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

3.2 ms3.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

140.8 ms139.6 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

77.1 ms76.5 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

128.2 ms127.6 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

46.9 ms46.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

246.8 ms245.7 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

38.3 ms38.2 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

63.2 ms62.9 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

224.9 µs224.1 µs

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

284.3 ms283.4 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

516.8 ms515.2 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

21.1 ms21 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.3 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

208.9 µs208.9 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.5 ms103.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

28 ms28 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.8 ms15.8 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.8 µs76.9 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75.1 ms75.2 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

377.9 ms378.3 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.6 µs100.9 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.6 µs22.6 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.3 ms18.4 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

-1%

56.6 ms57.1 ms

Commits

Click on a commit to change the comparison range

Base

main

a49f491

+0.14%

refactor(syntax): use `NonMaxU32` for IDs (#4467) `SymbolId` and `ReferenceId` are stored as `NonZeroU32`, but with a wrapper to make `u32::MAX` the illegal value, instead of `0`. Use the existing `nonmax` crate for this. Our current implementation uses `idx + 1` to avoid the zero value, whereas `nonmax` crate uses XOR `idx ^ u32::MAX`, which is a cheaper operation. Initially I made this change manually instead of pulling in a dependency, but it's a pain because it requires implementing `Debug` and `PartialOrd` by hand to handle the difference between the "actual" value and its stored representation. So I thought better to use a crate which does this for us.

96fc94f

1 year ago

by overlookmotel

Home Terms Privacy Docs