07-25-refactor_semantic_methods_take_span_as_param_not_span_ - Branch - oxc-project/oxc

refactor(semantic): methods take `Span` as param, not `&Span`

#4470Merged

Comparing

07-25-refactor_semantic_methods_take_span_as_param_not_span_

(

ccb1835

) with

main

(

a49f491

)

+1%

Untouched: 32

Benchmarks

Passed

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

21.1 ms20.6 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+2%

38.3 ms37.6 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

77.1 ms75.6 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+2%

128.2 ms125.9 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+2%

3.2 ms3.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+2%

140.8 ms138.5 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

63.2 ms62.4 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

246.8 ms243.7 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

224.9 µs222.4 µs

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

284.3 ms281.5 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+1%

516.8 ms511.7 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

772.1 ms765.8 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.3 s1.3 s

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

208.9 µs207.9 µs

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.8 ms15.8 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

28 ms28 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

100.6 µs100.5 µs

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.5 ms103.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

377.9 ms378 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75.1 ms75.1 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

46.9 ms47 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.6 µs22.6 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.3 ms18.4 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

56.6 ms56.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

-1%

76.8 µs77.3 µs

Commits

Click on a commit to change the comparison range

Base

main

a49f491

+0.55%

refactor(semantic): methods take `Span` as param, not `&Span` (#4470) `Span` is `Copy` and 8 bytes. So better to pass `Span` to functions, rather than `&Span` (which is also 8 bytes, but involves the indirection of a reference).

ccb1835

1 year ago

by overlookmotel

Home Terms Privacy Docs