07-25-fix_transformer_add_to_symboltable_declarations_for_all_symbols - Branch - oxc-project/oxc

fix(transformer): add to `SymbolTable::declarations` for all symbols

#4460Merged

Comparing

07-25-fix_transformer_add_to_symboltable_declarations_for_all_symbols

(

c04b9aa

) with

main

(

a49f491

)

Untouched: 32

Benchmarks

Passed

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

100.6 µs99.5 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.3 s1.3 s

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.8 µs76.7 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.2 ms3.2 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

140.8 ms140.8 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.8 ms15.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

246.8 ms246.8 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

77.1 ms77.1 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

38.3 ms38.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

516.8 ms516.8 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

28 ms28 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.5 ms103.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

377.9 ms377.9 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

284.3 ms284.3 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.3 ms18.3 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

128.2 ms128.2 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

63.2 ms63.2 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

224.9 µs225 µs

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

208.9 µs209 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.6 µs22.6 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

56.6 ms56.8 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

21.1 ms21.1 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

772.1 ms775 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-1%

75.1 ms75.7 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

46.9 ms47.7 ms

Commits

Click on a commit to change the comparison range

Base

main

a49f491

-0.06%

fix(transformer): add to `SymbolTable::declarations` for all symbols (#4460) `declarations` field of `SymbolTable` is part of the SoA group field. For it to be valid to index into with `SymbolId`, an entry must be added for every new symbol which is created.

c04b9aa

1 year ago

by overlookmotel

Home Terms Privacy Docs