07-24-perf_diagnostics_info_new_trim_string_in_place - Branch - oxc-project/oxc

perf(diagnostics): `Info::new` trim string in place

#12506Merged

Comparing

07-24-perf_diagnostics_info_new_trim_string_in_place

(

ce5d074

) with

main

(

85a34ce

)

Untouched: 34

No successful run was found on 07-24-refactor_diagnostics_implement_eq_and_ord_for_infoposition_ ( 5c33fc7) during the generation of this report, so main ( 85a34ce) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

26.4 ms26.2 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.7 ms1.7 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.2 ms4.2 ms

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

36.9 ms36.8 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

127.9 µs127.7 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

84.2 µs84.2 µs

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.7 ms1.7 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

28 ms28 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

10.3 ms10.3 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.3 ms4.3 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.3 ms1.3 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

134.8 µs134.8 µs

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

716.2 µs716.1 µs

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

26.8 ms26.8 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

162.3 ms162.3 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.9 µs20.9 µs

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

146.4 ms146.4 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

104.7 ms104.7 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.8 ms5.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.5 ms57.5 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4.7 ms4.7 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.5 ms2.5 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.3 ms3.3 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

53.4 ms53.4 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

929.9 µs930.3 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

384 µs384.4 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

2.7 ms2.7 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

1.9 ms1.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

77.1 µs77.2 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

307.2 µs307.6 µs

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

78.6 µs78.7 µs

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

20.6 ms20.7 ms

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

37.2 ms37.6 ms

Commits

Click on a commit to change the comparison range

Base

main

85a34ce

-0.02%

perf(diagnostics): `Info::new` trim string in place (#12506) Small optimization. `Info::new` trim message `String` in place, rather than creating a new `String` and dropping the old one. Why doesn't Rust have `String::trim_in_place` and `String::trim_start_matches_in_place`?

ce5d074

4 months ago

by overlookmotel

Home Terms Privacy Docs