07-21-perf_semantic_remove_bounds_checks_on_unresolved_references_stack - Branch - oxc-project/oxc

perf(semantic): remove bounds checks on unresolved references stack

#4390Merged

Comparing

07-21-perf_semantic_remove_bounds_checks_on_unresolved_references_stack

(

da13d93

) with

main

(

f7da22d

)

Untouched: 32

Benchmarks

Passed

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

26.5 ms26.2 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

233.3 µs231.7 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

774.5 ms770.6 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.4 ms18.3 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

104.4 ms104.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.9 ms3.9 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

208.5 µs208 µs

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

170.3 ms170 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

75.9 ms75.8 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.8 µs22.8 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

46.1 ms46 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75.2 ms75.1 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

691.2 ms690.7 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

174.8 ms174.7 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

108.9 µs108.9 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.5 ms103.5 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

379.5 ms379.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

28 ms28 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.8 ms15.8 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

298 ms298 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.2 µs77.3 µs

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

343.9 ms344 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

57 ms57.1 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.3 s1.3 s

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

56.5 ms57.2 ms

Commits

Click on a commit to change the comparison range

Base

main

f7da22d

+0.08%

perf(semantic): remove bounds checks on unresolved references stack (#4390) `SemanticBuilder` keeps a stack of hashmaps to track unresolved references. This stack only grows, never shrinks. Use that invariant to remove bounds checks.

da13d93

1 year ago

by overlookmotel

Home Terms Privacy Docs