07-19-refactor_semantic_program_visitor_leave_scope_before_node - Branch - oxc-project/oxc

refactor(semantic): `Program` visitor leave scope before node

#4369Merged

Comparing

07-19-refactor_semantic_program_visitor_leave_scope_before_node

(

f7b9ada

) with

main

(

aece1df

)

Untouched: 32

Benchmarks

Passed

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

56.7 ms56 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

233.9 µs232.8 µs

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

105.1 ms104.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77 µs76.9 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

57.2 ms57.1 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

208.7 µs208.6 µs

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.8 ms15.8 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

45.9 ms45.9 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.6 ms26.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

379.4 ms379.4 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

19.1 ms19.1 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

692.2 ms692.2 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.6 ms103.6 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

28 ms28 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

75.8 ms75.9 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

344.7 ms344.8 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

297.9 ms298.2 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.8 µs22.8 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

175.3 ms175.7 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

75.4 ms75.5 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

170.4 ms171.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

-1%

3.9 ms3.9 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

107.6 µs108.8 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

761.7 ms772.5 ms

Commits

Click on a commit to change the comparison range

Base

main

aece1df

-0.06%

refactor(semantic): `Program` visitor leave scope before node (#4369) Bring the order of calls in `SemanticBuilder::visit_program` into line with `Visit`'s `walk_program`.

f7b9ada

1 year ago

by overlookmotel

Home Terms Privacy Docs