07-19-perf_semantic_remove_branch_from_nodes_add_node_ - Branch - oxc-project/oxc

perf(semantic): remove branch from `Nodes::add_node`

#4361Merged

Comparing

07-19-perf_semantic_remove_branch_from_nodes_add_node_

(

7469e01

) with

main

(

729b288

)

Untouched: 32

Benchmarks

Passed

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

109.4 µs108 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.4 s1.4 s

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

+1%

76.6 ms75.9 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

+1%

57.4 ms57.1 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

770.4 ms767.4 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

105 ms104.6 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.7 ms26.6 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

298.6 ms297.8 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

170.7 ms170.2 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

344.6 ms344 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

207.2 µs206.8 µs

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

175.5 ms175.3 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

379.4 ms379.4 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.7 ms15.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.7 ms27.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.6 ms103.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.8 µs22.8 µs

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

19.1 ms19.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

691.5 ms691.6 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77 µs77 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.9 ms3.9 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

75.5 ms75.6 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

233.4 µs234 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

45.9 ms46.1 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

56.5 ms56.8 ms

Commits

Click on a commit to change the comparison range

Base

main

729b288

+0.14%

perf(semantic): remove branch from `Nodes::add_node` (#4361) `AstNodes::add_node` had a branch specifically to handle `Program`. Remove that by inlining the special logic for `Program` into `visit_program`. Probably won't have much effect on benchmarks as the branch is easy to predict, but still removes a few instructions and makes `add_node` easier for compiler to inline.

7469e01

1 year ago

by overlookmotel

Home Terms Privacy Docs