07-15-refactor_semantic_remove_defunct_code_setting_scopeflags_twice - Branch - oxc-project/oxc

refactor(semantic): remove defunct code setting ScopeFlags twice

#4286Merged

Comparing

07-15-refactor_semantic_remove_defunct_code_setting_scopeflags_twice

(

c5731a5

) with

main

(

2c7bb9f

)

Untouched: 32

Benchmarks

Passed

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

+1%

56.7 ms56.3 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

207.2 µs206.3 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

75.4 ms75.1 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

172.7 ms172.3 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

625.1 ms624.5 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

169.2 ms169 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.2 µs77.2 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.8 ms3.8 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

23.9 ms23.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.3 ms52.3 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.9 ms18.9 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.4 ms103.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.7 ms15.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

375.9 ms376 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.7 ms27.7 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

341.7 ms341.8 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

45.7 ms45.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

295.7 ms296 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

107.7 µs107.8 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

56.8 ms56.9 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

231.5 µs231.9 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 µs22.5 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.4 ms26.5 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

102.2 ms102.6 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

-1%

770.6 ms776.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-1%

74.7 ms75.3 ms

Commits

Click on a commit to change the comparison range

Base

main

2c7bb9f

-0.04%

refactor(semantic): remove defunct code setting ScopeFlags twice (#4286) Scope flags for functions is set when the scope is created. Remove redundant code that sets them again.

c5731a5

1 year ago

by overlookmotel

Home Terms Privacy Docs