07-15-refactor_ast_pass_final_scopeflags_into_visit_function_ - Branch - oxc-project/oxc

refactor(ast): pass final `ScopeFlags` into `visit_function`

#4283Merged

Comparing

07-15-refactor_ast_pass_final_scopeflags_into_visit_function_

(

2c7bb9f

) with

main

(

bf3d8d3

)

Untouched: 32

Benchmarks

Passed

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

1.4 s1.4 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

+1%

108.3 µs107.5 µs

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

102.7 ms102.3 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

231.9 µs231 µs

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

56.6 ms56.4 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

295.8 ms294.9 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

75.3 ms75.1 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

169.4 ms169.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.8 ms3.8 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

172.6 ms172.6 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

341.8 ms341.7 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.7 ms27.7 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms4.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.7 ms15.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

23.9 ms23.9 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17 ms17 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

103.4 ms103.4 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.9 ms18.9 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

77.2 µs77.2 µs

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.3 ms52.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

375.8 ms375.9 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

74.7 ms74.7 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

624.2 ms624.7 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

56.3 ms56.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

774.4 ms775.5 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

45.7 ms45.8 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

206.6 µs206.9 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.4 µs22.5 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

26.2 ms26.5 ms

Commits

Click on a commit to change the comparison range

Base

main

bf3d8d3

+0.05%

refactor(ast): pass final `ScopeFlags` into `visit_function` (#4283) We have a strange workaround for `visit_function` where we pass in `ScopeFlags`, to support creating the scope inside `Function`, but setting different flags for `MethodDefinition`s. Previously `visit_function` took `Option<ScopeFlags>` and then did `flags.unwrap_or(ScopeFlags::empty()) | ScopeFlags::Function` to it. Personally, I found this confusing. When I was looking at `MethodDefinition`, I was wondering "It's a function, why doesn't it set Function flag too?" This changes makes it more explicit and clear what `ScopeFlags` everything has.

2c7bb9f

1 year ago

by overlookmotel

Home Terms Privacy Docs