07-14-refactor_ast_move_enter_scope_after_visit_binding_identifier_ - Branch - oxc-project/oxc

refactor(ast): move `enter_scope` after `visit_binding_identifier`

#4246Merged

Comparing

07-14-refactor_ast_move_enter_scope_after_visit_binding_identifier_

(

3e099fe

) with

main

(

dc2b3c4

)

Untouched: 32

Benchmarks

Passed

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

+1%

791.6 ms780.9 ms

prepass[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

+1%

206.8 µs205.7 µs

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

184.5 ms183.8 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

4 ms4 ms

sourcemap[cal.com.tsx]

tasks/benchmark/benches/sourcemap.rs::sourcemap::bench_sourcemap

56.5 ms56.4 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.4 s1.4 s

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

250.8 µs250.5 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

50.2 ms50.2 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.5 µs22.4 µs

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

319.8 ms319.4 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

350.4 ms350.1 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

81.4 ms81.4 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5 ms5 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.2 ms3.2 ms

prepass[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

27.7 ms27.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

104 ms104 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.1 ms20.1 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.1 ms17.1 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

12 ms12 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

18.4 ms18.4 ms

prepass[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_passes

15.7 ms15.7 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

52.4 ms52.4 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

24 ms24 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

648.2 ms648.4 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

76.9 µs76.9 µs

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

375.2 ms375.7 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

116.9 ms117.6 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

196.2 ms197.2 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

125 µs126 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

-1%

74.2 ms74.8 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

62.2 ms62.9 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-2%

30 ms30.5 ms

Commits

Click on a commit to change the comparison range

Base

main

dc2b3c4

-0.06%

refactor(ast): move `enter_scope` after `visit_binding_identifier` (#4246) This is now consistent with other ASTs that require bind https://github.com/oxc-project/oxc/blob/2019043e726cbbe2d2cd4bb49620110298798294/crates/oxc_ast/src/ast/ts.rs#L814-L815

3e099fe

1 year ago

by Dunqing

Home Terms Privacy Docs