06-16-perf_linter_no-inner-declarations_move_work_to_cold_path - Branch - oxc-project/oxc

perf(linter/no-inner-declarations): move work to cold path

#11746Merged

Comparing

06-16-perf_linter_no-inner-declarations_move_work_to_cold_path

(

cfdc518

) with

main

(

80c87d4

)

Untouched: 38

Benchmarks

Passed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+2%

23.8 ms23.3 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

+2%

807.8 µs795 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

329.7 µs328.7 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

38.9 ms38.8 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

132.5 µs132.3 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

638 µs637.5 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.6 ms4.6 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.5 ms57.5 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.4 ms1.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.5 ms1.5 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

161 ms161 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

20.6 ms20.6 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.4 ms3.4 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

149.7 ms149.7 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.8 ms4.8 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.9 µs20.9 µs

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

27.2 ms27.2 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.8 ms5.8 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

930.1 µs930.1 µs

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

102.6 ms102.6 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.5 ms3.5 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.6 ms2.6 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

54.8 ms54.8 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

29.7 ms29.7 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.8 ms1.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

85.1 µs85.1 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

384.1 µs384.2 µs

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

2.2 ms2.2 ms

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

3.1 ms3.1 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

284 µs284.3 µs

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

10.1 ms10.1 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

24.7 ms24.7 ms

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

65.6 µs65.8 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

129.3 µs129.7 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

82.2 µs82.9 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

-3%

14.1 µs14.5 µs

Commits

Click on a commit to change the comparison range

Base

main

80c87d4

perf(linter/no-inner-declarations): move work to cold path (#11746) Small perf optimization to `eslint/no-inner-declarations` rule. Common case is that rules will not trigger an error, so move as much work as possible to after the checks which exit without error.

cfdc518

5 months ago

by overlookmotel

Home Terms Privacy Docs