06-16-perf_allocator_remove_arc_from_allocatorpool_ - Branch - oxc-project/oxc

perf(allocator): remove `Arc` from `AllocatorPool`

#11760Merged

Comparing

06-16-perf_allocator_remove_arc_from_allocatorpool_

(

f539f64

) with

main

(

17f5dbe

)

Untouched: 38

Benchmarks

Passed

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

+3%

23.8 ms23.2 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

284.2 µs283.4 µs

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

3.1 ms3.1 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.9 µs20.9 µs

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

132.5 µs132.3 µs

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.6 ms4.5 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.5 ms1.5 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

29.7 ms29.7 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.6 ms2.6 ms

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

384 µs384 µs

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

929.9 µs929.8 µs

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

54.8 ms54.8 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

2.2 ms2.2 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.8 ms5.8 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

102.6 ms102.6 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

149.7 ms149.7 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

161 ms161 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

27.2 ms27.2 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.4 ms1.4 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.5 ms3.5 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.4 ms3.4 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

20.6 ms20.6 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

637.9 µs638.2 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

129.3 µs129.3 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

329.2 µs329.3 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.4 ms57.5 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

10.1 ms10.1 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.8 ms1.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

84.6 µs84.7 µs

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.8 ms4.8 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

807.9 µs809.4 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

38.8 ms38.8 ms

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

65.5 µs65.7 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

-1%

14.1 µs14.2 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

82.4 µs83.1 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

24.6 ms25 ms

Commits

Click on a commit to change the comparison range

Base

main

17f5dbe

-0.02%

perf(allocator): remove `Arc` from `AllocatorPool` (#11760) Follow-on after #11736. Remove the overhead of `Arc` from `AllocatorPool`. This does introduce more lifetimes in linter, which is unwelcome, but as well as removing the synchronization overhead of `Arc`, I think it reflects the semantics of what we're trying to do more correctly. `AllocatorPool` solely owns the `Vec<Allocator>` pool. It doesn't need to (and shouldn't) share ownership of it with `AllocatorGuard`s, which `Arc` does. So `AllocatorGuard`s can just hold a reference to the `AllocatorPool`.

f539f64

5 months ago

by overlookmotel

Home Terms Privacy Docs