06-16-fix_ast_estree_remove_custom_serializer_for_methoddefinition_key_field - Branch - oxc-project/oxc

fix(ast/estree): remove custom serializer for `MethodDefinition` `key` field

#11763Merged

Comparing

06-16-fix_ast_estree_remove_custom_serializer_for_methoddefinition_key_field

(

6feab7e

) with

main

(

01e52bc

)

+15%

Improvements: 1

Untouched: 37

Benchmarks

Improved

mangler[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

+15%

3.5 ms3.1 ms

Passed

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

25 ms24.7 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

85.1 µs84.8 µs

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

65.7 µs65.5 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

14 µs14 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

129.4 µs129.1 µs

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

1.4 ms1.4 ms

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

637.9 µs637.1 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

38.9 ms38.9 ms

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

132.4 µs132.3 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

29.8 ms29.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

27.2 ms27.2 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

4.8 ms4.8 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

284.7 µs284.6 µs

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

161.1 ms161 ms

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

3.4 ms3.4 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

3.5 ms3.5 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

102.6 ms102.6 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

4.5 ms4.5 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

83 µs83 µs

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

20.6 ms20.6 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

929.8 µs929.7 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.8 ms5.8 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

149.7 ms149.7 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter

54.8 ms54.8 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

10.1 ms10.1 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

383.9 µs384 µs

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.6 ms2.6 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations

57.5 ms57.5 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

1.8 ms1.8 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

1.5 ms1.5 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

2.2 ms2.2 ms

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

809 µs809.7 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

23.2 ms23.2 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.9 µs20.9 µs

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

328.9 µs329.7 µs

Commits

Click on a commit to change the comparison range

Base

main

01e52bc

+14.88%

fix(ast/estree): remove custom serializer for `MethodDefinition` `key` field (#11763) Remove the custom ESTree serializer for `MethodDefinition`'s `key` field. This serializer was required to replicate a bug in TS-ESLint, which they've now fixed. This fixes the test case which was broken by #11762.

6feab7e

5 months ago

by overlookmotel

Home Terms Privacy Docs