06-03-refactor_language_server_simplify_workspace_didchangeconfiguration_call - Branch - oxc-project/oxc

oxc-project

oxc

Instrumentation

Wall Time

Blog Docs Changelog

refactor(language_server): simplify `workspace/didChangeConfiguration` call

#11462Merged

Comparing

06-03-refactor_language_server_simplify_workspace_didchangeconfiguration_call

(

ccceb52

) with

main

(

953e61b

)

-13%

Improvements: 0

Regressions: 1

Untouched: 37

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Failed

mangler[cal.com.tsx]Regression

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[cal.com.tsx]

-13%

3 ms

3.5 ms

Passed

mangler[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[binder.ts]

+2%

816.3 µs

798.6 µs

mangler[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[RadixUIAdoptionSection.jsx]

+1%

14.2 µs

14.1 µs

codegen[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[RadixUIAdoptionSection.jsx]

132.5 µs

132.1 µs

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler::mangler[react.development.js]

283.1 µs

282.4 µs

codegen[cal.com.tsx]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[cal.com.tsx]

38.9 ms

minifier[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[RadixUIAdoptionSection.jsx]

65.9 µs

65.8 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[RadixUIAdoptionSection.jsx]

21.1 µs

21 µs

minifier[cal.com.tsx]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[cal.com.tsx]

23.5 ms

23.4 ms

linter[react.development.js]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[react.development.js]

54.7 ms

minifier[binder.ts]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[binder.ts]

3.5 ms

codegen[react.development.js]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[react.development.js]

2.2 ms

lexer[binder.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[binder.ts]

929.4 µs

929.3 µs

lexer[react.development.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[react.development.js]

383.7 µs

383.6 µs

transformer[react.development.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[react.development.js]

637.1 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer::lexer[cal.com.tsx]

5.8 ms

formatter[cal.com.tsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[cal.com.tsx]

150.4 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier::minifier[react.development.js]

1.8 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree::estree[checker.ts]

103.4 ms

linter[binder.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[binder.ts]

149.2 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[cal.com.tsx]

1.3 s

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter::linter[RadixUIAdoptionSection.jsx]

2.8 ms

formatter[binder.ts]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[binder.ts]

19.3 ms

formatter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[RadixUIAdoptionSection.jsx]

300.1 µs

parser[binder.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[binder.ts]

3.4 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[cal.com.tsx]

24.7 ms

transformer[binder.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[binder.ts]

1.5 ms

parser[react.development.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[react.development.js]

1.4 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[cal.com.tsx]

25.4 ms

codegen[binder.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen::codegen[binder.ts]

4.8 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter::formatter[react.development.js]

9.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[cal.com.tsx]

27.4 ms

semantic[binder.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[binder.ts]

3.9 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_isolated_declarations::isolated-declarations[vue-id.ts]

57.4 ms

57.5 ms

semantic[react.development.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[react.development.js]

1.5 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser::parser[RadixUIAdoptionSection.jsx]

85.3 µs

85.4 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer::transformer[RadixUIAdoptionSection.jsx]

129.3 µs

129.7 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic::semantic[RadixUIAdoptionSection.jsx]

-1%

72 µs

72.4 µs

Commits

Click on a commit to change the comparison range

Base

main

953e61b

-13%

refactor(language_server): simplify `workspace/didChangeConfiguration` call (#11462) Before: Check if client passed valid options, iterate over them, fill the mutable vecs. If not valid options are passed, check for configuration support, request, iterate over them, fill the mutable vecs. After: Check if client passed valid options, if not check for configuration support, request them and map to workspace configuration. Iterate over the result and fill the mutable vecs.

ccceb52

3 months ago

by Sysix

Home Terms Privacy Docs