04-16-refactor_parser_shorten_code - Branch - oxc-project/oxc

refactor(parser): shorten code

#10445Merged

Comparing

04-16-refactor_parser_shorten_code

(

a6b2232

) with

main

(

c6f08d0

)

Untouched: 36

Benchmarks

Passed

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

135.7 µs134.6 µs

formatter[typescript.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

815 ms813.5 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

30.2 ms30.1 ms

formatter[antd.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

638.4 ms637.3 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

10.1 ms10.1 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

58.4 ms58.4 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

63.8 ms63.8 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.9 ms56.9 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

163.5 ms163.5 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.9 ms5.9 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

287.7 ms287.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

113.5 ms113.5 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.9 ms14.9 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

65.2 ms65.2 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.8 ms24.8 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

22.2 ms22.2 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

96.9 ms96.9 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.9 ms3.9 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.4 ms39.4 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

22 ms22 ms

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

15.9 ms15.9 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

32.9 ms32.9 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

49.8 ms49.8 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.3 ms18.3 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

103.4 ms103.4 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

3 s3 s

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

25.9 ms25.9 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

293 µs293.3 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

16.9 ms16.9 ms

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

6.1 ms6.1 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

92.3 µs92.4 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.5 µs21.5 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

73.7 µs73.8 µs

Commits

Click on a commit to change the comparison range

Base

main

c6f08d0

+0.02%

refactor(parser): shorten code (#10445) Pure refactor. Use `into_expression` instead of `Expression::try_from(elem).unwrap()`. They do the same thing, but the former is shorter.

a6b2232

8 months ago

by overlookmotel

Home Terms Privacy Docs