04-06-refactor_ast_remove_jsxopeningelement_self_closing_field - Branch - oxc-project/oxc

refactor(ast)!: remove `JSXOpeningElement::self_closing` field

#10275Merged

Comparing

04-06-refactor_ast_remove_jsxopeningelement_self_closing_field

(

a26fd34

) with

main

(

78f1b3a

)

Untouched: 36

Benchmarks

Passed

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

74.2 µs74 µs

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.9 ms1.8 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

92.3 µs92.2 µs

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

291.7 ms291.3 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

293.6 µs293.3 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.1 ms26.1 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

165.5 ms165.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.7 ms56.6 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.3 ms18.3 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

58.3 ms58.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

65.2 ms65.1 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

52.4 ms52.4 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.4 ms39.4 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.8 ms24.8 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

64.2 ms64.2 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

96.9 ms96.9 ms

formatter[antd.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

7.9 ms7.9 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

113.5 ms113.5 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.2 µs21.2 µs

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17 ms17 ms

formatter[typescript.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

7.2 ms7.2 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.8 ms14.8 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.9 ms5.9 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

23.3 ms23.3 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.9 ms3.9 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

10.6 ms10.6 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

22.1 ms22.1 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

104.3 ms104.4 ms

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

15.9 ms15.9 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

30.1 ms30.1 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

3 s3 s

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

43.6 µs43.6 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

34.1 ms34.1 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

144.5 µs144.9 µs

Commits

Click on a commit to change the comparison range

Base

main

78f1b3a

+0.01%

refactor(ast)!: remove `JSXOpeningElement::self_closing` field (#10275) Remove `self_closing` field from `JSXOpeningElement`. Whether the tag is self-closing can be determined by whether the `JSXElement` has a `closing_element` or not. This is advantageous for 2 reasons: 1. Reduce size of `JSXOpeningElement` by 8 bytes. 2. Make it impossible for `self_closing` and `closing_element` fields to get out of sync. Only one source of truth.

a26fd34

10 months ago

by overlookmotel

Home Terms Privacy Docs