04-03-refactor_ast_estree_alter_program_start_span_with_converter - Branch - oxc-project/oxc

refactor(ast/estree): alter `Program` start span with converter

#10195Merged

Comparing

04-03-refactor_ast_estree_alter_program_start_span_with_converter

(

b662df4

) with

main

(

abc9ea4

)

-5%

Regressions: 1

Untouched: 35

Benchmarks

Failed

formatter[react.development.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

Regression

-5%

41.4 µs43.5 µs

Passed

formatter[typescript.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

+2%

7.6 ms7.4 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

74 µs73.7 µs

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.5 µs21.5 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

92.3 µs92.1 µs

formatter[antd.js]

tasks/benchmark/benches/formatter.rs::formatter::bench_formatter

7.6 ms7.6 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17.1 ms17 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

22.5 ms22.5 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

294.8 µs294.5 µs

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

64.2 ms64.2 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

10.4 ms10.4 ms

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

16 ms16 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.9 ms1.9 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.1 ms26.1 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.9 ms3.9 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

113.3 ms113.2 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.8 ms24.8 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

96.9 ms96.9 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

166.2 ms166.2 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.8 ms14.8 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

293.2 ms293.2 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

23.1 ms23.1 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.2 ms18.2 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

58.3 ms58.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.9 ms5.9 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.8 ms51.8 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

104.3 ms104.3 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.7 ms56.7 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

34 ms34 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

144.7 µs144.7 µs

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.9 s2.9 s

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.7 ms39.7 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

30.1 ms30.1 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

65.4 ms65.5 ms

Commits

Click on a commit to change the comparison range

Base

main

abc9ea4

-4.8%

refactor(ast/estree): alter `Program` start span with converter (#10195) #10134 fixed the start span of `Program` in TS AST to align with TS-ESLint. Change the method this is achieved by - use a custom converter instead of mutating the AST in `to_estree_ts_json` and `to_pretty_estree_ts_json`. This method is more convoluted, but I think it's preferable if serialization does not have side effect of mutating the AST.

b662df4

9 months ago

by overlookmotel

Home Terms Privacy Docs