03-28-fix_codegen_prevent_arithmetic_overflow_calculating_quote_for_stringliteral_s - Branch - oxc-project/oxc

fix(codegen): prevent arithmetic overflow calculating quote for `StringLiteral`s

#10102Merged

Comparing

03-28-fix_codegen_prevent_arithmetic_overflow_calculating_quote_for_stringliteral_s

(

c903e42

) with

main

(

d190466

)

Untouched: 33

Benchmarks

Passed

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

295.8 µs294.4 µs

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

65.7 ms65.6 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17.1 ms17.1 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.9 s2.9 s

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

16 ms16 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

113.2 ms113.2 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.7 ms39.7 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.7 ms51.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

23.1 ms23.1 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

11.5 ms11.5 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.6 ms56.6 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

96.9 ms96.9 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

291.6 ms291.6 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

165.6 ms165.6 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.4 µs21.4 µs

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.8 ms14.8 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

22.6 ms22.6 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

64.3 ms64.3 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.9 ms5.9 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.2 ms18.2 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.8 ms24.8 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

104.4 ms104.4 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.9 ms3.9 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

58.3 ms58.3 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

30 ms30.1 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

144.1 µs144.3 µs

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

92.1 µs92.3 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.1 ms26.2 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

33.9 ms34 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

73 µs73.8 µs

Commits

Click on a commit to change the comparison range

Base

03-27-perf_codegen_faster_printing_quotes

d190466

-0.04%

fix(codegen): prevent arithmetic overflow calculating quote for `StringLiteral`s (#10102) Code for calculating the optimum quote character to use for `StringLiteral`s could in theory produce arithmetic overflow (panic in debug mode, malfunction in release mode) if the string is very long and contains a very large number of quote characters e.g. `"''''''''''''"` (but much much longer). Fix that by using `i64` instead of `i32` for the counter variables.

c903e42

9 months ago

by overlookmotel

Home Terms Privacy Docs