03-18-fix_ast_estree_fix_function.this_param_ - Branch - oxc-project/oxc

fix(ast/estree): fix `Function.this_param`

#9913Merged

Comparing

03-18-fix_ast_estree_fix_function.this_param_

(

8228b74

) with

main

(

5631ebd

)

Untouched: 33

Benchmarks

Passed

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

21.4 µs21.4 µs

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

22.6 ms22.6 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

65.8 ms65.7 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

291.7 µs291.4 µs

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

96.8 ms96.8 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.1 ms26.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

74.5 µs74.5 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

3 s3 s

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

15.8 ms15.8 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

104.9 ms104.9 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

288.7 ms288.7 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.9 ms5.9 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.8 ms14.8 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

23.1 ms23.1 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

58.3 ms58.3 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.2 ms39.2 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

51.5 ms51.5 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

163.9 ms163.9 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.8 ms24.8 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.9 ms3.9 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17.1 ms17.1 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

10.3 ms10.3 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

64.3 ms64.4 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.6 ms56.7 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

113.1 ms113.2 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

30.1 ms30.1 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

34.3 ms34.4 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.2 ms18.3 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

-1%

92 µs92.7 µs

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

145.6 µs146.7 µs

Commits

Click on a commit to change the comparison range

Base

main

5631ebd

-0.03%

fix(ast/estree): fix `Function.this_param` (#9913) `Function.this_param` is included in `Function.params` as an `Identifier` with `name: "this"` https://ast-explorer.dev/#eNolykEKwzAMRNGrmFm10F7AB+lKG2MU6uAoJlICwfjuUchiNu9PR0XEnI6keSvN8EFzsLPxA1/WWuT27D7tkq2sEqaX/YvG0Mfb53X12klCIHBe0o839R8hOtRkrEYgGRgXircmAw==

8228b74

9 months ago

by hi-ogawa

Home Terms Privacy Docs