03-11-refactor_transformer_using_shorten_astbuilder_calls - Branch - oxc-project/oxc

refactor(transformer/using): shorten `AstBuilder` calls

#9674Merged

Comparing

03-11-refactor_transformer_using_shorten_astbuilder_calls

(

3180c65

) with

main

(

474a57b

)

Untouched: 39

Benchmarks

Passed

parser_napi[RadixUIAdoptionSection.jsx]

napi/parser/bench.bench.mjs

+3%

4.9 ms4.8 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

35.3 ms35 ms

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.8 µs20.7 µs

parser_napi_raw[RadixUIAdoptionSection.jsx]

napi/parser/bench.bench.mjs

1.3 ms1.3 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

146.2 µs146 µs

parser_napi_raw[pdf.mjs]

napi/parser/bench.bench.mjs

266.3 ms266 ms

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.6 ms26.6 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

29.7 ms29.7 ms

parser_napi_raw[checker.ts]

napi/parser/bench.bench.mjs

1.1 s1.1 s

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

65.3 ms65.3 ms

parser_napi_raw[cal.com.tsx]

napi/parser/bench.bench.mjs

700.2 ms700 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

66.2 ms66.2 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17.3 ms17.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

294.6 ms294.5 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

112.1 ms112.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

25.6 ms25.6 ms

parser_napi[pdf.mjs]

napi/parser/bench.bench.mjs

1.8 s1.8 s

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

55.3 ms55.3 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.5 ms14.5 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.1 ms24.1 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

167.6 ms167.6 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.5 ms56.5 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

23.1 ms23.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.7 ms5.7 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

88.4 ms88.4 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

294.7 µs294.8 µs

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.8 ms3.8 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.1 ms18.1 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

58.7 ms58.7 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

106.3 ms106.4 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.7 ms39.8 ms

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

16.1 ms16.1 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

88.7 µs88.8 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.9 s3 s

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

73.9 µs74.1 µs

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

11.1 ms11.1 ms

Commits

Click on a commit to change the comparison range

Base

main

474a57b

+0.09%

refactor(transformer/using): shorten `AstBuilder` calls (#9674) Follow-on after #9310. Pure refactor. Use shorter `AstBuilder` calls where possible. It's always preferable to use the `alloc_*` methods where possible, as it maximizes the chances compiler can see it can construct nodes directly in arena, rather than construct on stack and then copy to arena.

3180c65

10 months ago

by overlookmotel

Home Terms Privacy Docs