03-02-fix_minifier_don_t_inline_iife_with_parameters - Branch - oxc-project/oxc

fix(minifier): don't inline IIFE with parameters

#9477Merged

Comparing

03-02-fix_minifier_don_t_inline_iife_with_parameters

(

0b96ebe

) with

main

(

d65386a

)

Untouched: 33

Benchmarks

Passed

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.8 µs20.7 µs

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

297.9 µs296.8 µs

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.9 s2.9 s

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26.1 ms26.1 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.8 ms39.8 ms

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

16.2 ms16.1 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

29.8 ms29.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

57.3 ms57.2 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

64.3 ms64.3 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

10.6 ms10.6 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.7 ms3.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

24 ms24 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

25 ms25 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

54.9 ms54.9 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

88.2 µs88.2 µs

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.6 ms5.6 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

91.7 ms91.7 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

22.8 ms22.8 ms

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

109.1 ms109.1 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

13.7 ms13.7 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

162.4 ms162.4 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

17.7 ms17.8 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

105.2 ms105.3 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

284.4 ms284.5 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17.3 ms17.3 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

68.1 ms68.1 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

53.3 ms53.3 ms

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

34.5 ms34.5 ms

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

-1%

144 µs145.1 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

73 µs73.8 µs

Commits

Click on a commit to change the comparison range

Base

main

d65386a

-0.03%

fix(minifier): don't inline IIFE with parameters (#9477) `(a => { a() })()` should not be inlined (requires checking default parameters). this PR should fix the case written in https://github.com/rolldown/rolldown/pull/3725#issuecomment-2692485730 .

0b96ebe

10 months ago

by sapphi-red

Home Terms Privacy Docs