03-01-fix_linter_support_nested_extending - Branch - oxc-project/oxc

fix(linter): support nested extending

#9472Merged

Comparing

03-01-fix_linter_support_nested_extending

(

5ecda01

) with

main

(

fc74849

)

Untouched: 33

Benchmarks

Passed

transformer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

145 µs143.7 µs

transformer[cal.com.tsx]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

+1%

34.5 ms34.3 ms

linter[checker.ts]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.9 s2.9 s

lexer[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

20.8 µs20.8 µs

mangler[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

16.2 ms16.1 ms

mangler[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

39.8 ms39.8 ms

isolated-declarations[vue-id.ts]

tasks/benchmark/benches/isolated_declarations.rs::transformer::bench_isolated_declarations

57.9 ms57.9 ms

codegen_sourcemap[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

66.2 ms66.2 ms

lexer[pdf.mjs]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

3.8 ms3.8 ms

linter[cal.com.tsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

1.2 s1.2 s

parser[antd.js]

tasks/benchmark/benches/parser.rs::parser::bench_parser

111.9 ms111.9 ms

lexer[antd.js]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

24.1 ms24.1 ms

lexer[cal.com.tsx]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

5.7 ms5.7 ms

transformer[checker.ts]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

24 ms24 ms

parser[cal.com.tsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

30.1 ms30.1 ms

estree[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_estree

91.8 ms91.8 ms

parser[pdf.mjs]

tasks/benchmark/benches/parser.rs::parser::bench_parser

18.1 ms18.1 ms

lexer[checker.ts]

tasks/benchmark/benches/lexer.rs::lexer::bench_lexer

14.5 ms14.5 ms

minifier[typescript.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

285.8 ms285.8 ms

parser[checker.ts]

tasks/benchmark/benches/parser.rs::parser::bench_parser

56.3 ms56.3 ms

minifier[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

1.8 ms1.8 ms

transformer[antd.js]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

53.3 ms53.3 ms

minifier[antd.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_minifier

163 ms163 ms

linter[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/linter.rs::linter::bench_linter

2.7 ms2.7 ms

transformer[pdf.mjs]

tasks/benchmark/benches/transformer.rs::transformer::bench_transformer

10.6 ms10.6 ms

semantic[checker.ts]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

64.3 ms64.3 ms

semantic[antd.js]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

104.6 ms104.6 ms

parser[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/parser.rs::parser::bench_parser

89 µs89 µs

semantic[cal.com.tsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

26 ms26.1 ms

semantic[pdf.mjs]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

17.1 ms17.1 ms

codegen[checker.ts]

tasks/benchmark/benches/codegen.rs::codegen::bench_codegen

23.1 ms23.1 ms

mangler[react.development.js]

tasks/benchmark/benches/minifier.rs::minifier::bench_mangler

297.5 µs298 µs

semantic[RadixUIAdoptionSection.jsx]

tasks/benchmark/benches/semantic.rs::semantic::bench_semantic

-1%

72.8 µs73.4 µs

Commits

Click on a commit to change the comparison range

Base

main

fc74849

+0.03%

fix(linter): support nested extending (#9472) - part of https://github.com/oxc-project/oxc/issues/9307 Allows for using the `extends` keyword to chain multiple extended config files together: for example, a package config that extends a base config that extends a config from `node_modules` and so on. I don't really love what we're having to do here with using both `override_rules` and `ConfigStoreBuilder.with_rule`. I think there is a refactoring opportunity to merge some functionality together here, but I don't want to refactor and optimize before we have a more comprehensive test suite.

5ecda01

10 months ago

by camchenry

Home Terms Privacy Docs