refactor/deduplicate-filesystem-read - Branch - oxc-project/oxc-resolver

refactor(file_system): deduplicate read methods and use Vec<u8>

#816Merged

Comparing

refactor/deduplicate-filesystem-read

(

6b1c9ed

) with

main

(

aa90a41

)

Untouched: 10

Skipped: 5

No successful run was found on main ( 6b1c9ed) during the generation of this report, so aa90a41 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (5)

These benchmarks were skipped, so their baseline results are used instead. If they were deleted in your codebase, archive them to remove them from the performance reports.
Learn more about archiving benchmarks

parallel_batch_4_files

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

Skipped

91.1 µs*

batch_4_files

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

Skipped

78.6 µs*

resolver[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver

Skipped

61 ms*

resolver[multi-thread]

benches/resolver.rs::resolver::bench_resolver

Skipped

508.7 µs*

resolver[single-thread]

benches/resolver.rs::resolver::bench_resolver

Skipped

476.3 µs*

Passed

resolver_memory[multi-thread]

benches/resolver.rs::resolver::bench_resolver_memory

+1%

511.6 µs507 µs

complex_real

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

22.9 µs22.8 µs

resolver_memory[single-thread]

benches/resolver.rs::resolver::bench_resolver_memory

499.6 µs498.4 µs

small

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

11.8 µs11.8 µs

large

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

27.2 µs27.2 µs

resolver_real[single-thread]

benches/resolver.rs::resolver::bench_resolver_real

496.5 µs495.8 µs

resolver_memory[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_memory

60.4 ms60.4 ms

medium

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

17.3 µs17.3 µs

resolver_real[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_real

60.9 ms61 ms

resolver_real[multi-thread]

benches/resolver.rs::resolver::bench_resolver_real

-3%

499 µs513.4 µs

Commits

Click on a commit to change the comparison range

Base

main

aa90a41

-0.12%

refactor(file_system): deduplicate read methods and use Vec<u8> (#816) ## Summary Refactors the FileSystem trait to eliminate code duplication and improve maintainability: - Added `read()` method returning `Vec<u8>` as the primary file reading method - Deduplicated `read_to_string()` to call `read()` + UTF-8 validation - Removed `read_to_string_bypass_system_cache()` method (simplified API) - Updated `PackageJson::parse()` to work with `Vec<u8>` instead of `String` 🤖 Generated with [Claude Code](https://claude.com/claude-code)

6b1c9ed

7 days ago

by Boshen

Home Terms Privacy Docs