clear_cache - Branch - oxc-project/oxc-resolver

fix: store PathBuf with weak pointers to handle cache clearing

#879Merged

Comparing

clear_cache

(

2492bd2

) with

main

(

9b82017

)

-5%

Improvements: 1

Regressions: 1

Untouched: 10

Skipped: 5

No successful run was found on main ( 2492bd2) during the generation of this report, so 9b82017 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (5)

Failed

resolver_real[multi-thread]

benches/resolver.rs::resolver::bench_resolver_real

Regression

-5%

469.6 µs493.1 µs

Improved

small

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+4%

11.6 µs11.2 µs

Passed

large

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+2%

26.7 µs26.2 µs

medium

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+1%

17.1 µs16.9 µs

complex_real

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+1%

22.6 µs22.4 µs

resolver_memory[multi-thread]

benches/resolver.rs::resolver::bench_resolver_memory

473.1 µs473.2 µs

resolver_memory[drop]

benches/resolver.rs::resolver::bench_resolver_memory

84.8 ms84.9 ms

resolver_real[single-thread]

benches/resolver.rs::resolver::bench_resolver_real

467.4 µs468.9 µs

resolver_memory[single-thread]

benches/resolver.rs::resolver::bench_resolver_memory

-1%

468 µs472.6 µs

resolver_real[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_real

-2%

55 ms55.9 ms

resolver_memory[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_memory

-2%

54.8 ms55.8 ms

resolver_memory[find tsconfig]

benches/resolver.rs::resolver::bench_resolver_memory

-2%

13.8 µs14.1 µs

Commits

Click on a commit to change the comparison range

Base

main

9b82017

-4.77%

fix: store PathBuf with weak pointers to handle cache clearing (#879) fixes of #872 The solution is not optimal, I spent the whole day trying to understand synchronization but couldn't figure it out, so resorting to this really bad implementation. The good news is that I came up with a simple failing test for future improvements.

2492bd2

4 days ago

by Boshen

Home Terms Privacy Docs