11-18-refactor_do_not_store_is_symlink_in_cachedpathimpl - Branch - oxc-project/oxc-resolver

refactor: do not store is_symlink in CachedPathImpl

#850Merged

Comparing

11-18-refactor_do_not_store_is_symlink_in_cachedpathimpl

(

be1e1b4

) with

main

(

3a9d5e7

)

-1%

Untouched: 11

Skipped: 5

No successful run was found on main ( be1e1b4) during the generation of this report, so 3a9d5e7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (5)

Passed

resolver_memory[multi-thread]

benches/resolver.rs::resolver::bench_resolver_memory

469.1 µs467 µs

resolver_memory[single-thread]

benches/resolver.rs::resolver::bench_resolver_memory

470.8 µs470.5 µs

resolver_memory[drop]

benches/resolver.rs::resolver::bench_resolver_memory

84.8 ms84.8 ms

resolver_real[single-thread]

benches/resolver.rs::resolver::bench_resolver_real

464.3 µs465.3 µs

resolver_real[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_real

58.6 ms58.8 ms

resolver_real[multi-thread]

benches/resolver.rs::resolver::bench_resolver_real

468 µs469.8 µs

resolver_memory[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_memory

-1%

58.5 ms58.8 ms

large

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

-1%

26.4 µs26.7 µs

complex_real

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

-1%

22.3 µs22.6 µs

medium

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

-1%

17.2 µs17.4 µs

small

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

-2%

11.8 µs12 µs

Commits

Click on a commit to change the comparison range

Base

main

3a9d5e7

-0.59%

refactor: do not store is_symlink in CachedPathImpl (#850) `std::fs::metadata` always return `is_symlink: false` so it's confusing and pointless to store it in CachedPathImpl

be1e1b4

5 days ago

by Boshen

Home Terms Privacy Docs