11-18-fix_do_not_resolve_to_node_modules_pacakge_index_ - Branch - oxc-project/oxc-resolver

fix: do not resolve to `node_modules/pacakge/index`

#849Merged

Comparing

11-18-fix_do_not_resolve_to_node_modules_pacakge_index_

(

3a9d5e7

) with

main

(

ea425f6

)

Untouched: 11

Skipped: 5

No successful run was found on main ( 3a9d5e7) during the generation of this report, so ea425f6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (5)

Passed

complex_real

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+1%

22.4 µs22.3 µs

small

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

11.9 µs11.8 µs

large

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

26.5 µs26.4 µs

resolver_memory[multi-thread]

benches/resolver.rs::resolver::bench_resolver_memory

485.6 µs484.5 µs

resolver_real[single-thread]

benches/resolver.rs::resolver::bench_resolver_real

464.5 µs464.3 µs

medium

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

17.2 µs17.2 µs

resolver_memory[drop]

benches/resolver.rs::resolver::bench_resolver_memory

84.8 ms84.8 ms

resolver_memory[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_memory

58.5 ms58.5 ms

resolver_real[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_real

58.5 ms58.6 ms

resolver_memory[single-thread]

benches/resolver.rs::resolver::bench_resolver_memory

469.8 µs470.8 µs

resolver_real[multi-thread]

benches/resolver.rs::resolver::bench_resolver_real

464.4 µs466.5 µs

Commits

Click on a commit to change the comparison range

Base

main

ea425f6

+0.09%

fix: do not resolve to `node_modules/pacakge/index` (#849) fixes #845 The option `main_files` is kind of confusing, it's supposed to be the file stem without the extension (e.g. index), but somehow it ended up being a lookup for `index` then `index.js` instead of just `index.js`. This reduces an extra "is file" system call for `node_modules/package/index`.

3a9d5e7

7 days ago

by Boshen

Home Terms Privacy Docs