11-04-fix_skip_loading_tsconfig.json_from_virtual_module_paths - Branch - oxc-project/oxc-resolver

fix: skip loading tsconfig.json from virtual module paths

#809Merged

Comparing

11-04-fix_skip_loading_tsconfig.json_from_virtual_module_paths

(

7ea7e65

) with

main

(

c957d95

)

+1%

Untouched: 10

Skipped: 5

No successful run was found on main ( 7ea7e65) during the generation of this report, so c957d95 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (5)

Passed

resolver_memory[multi-thread]

benches/resolver.rs::resolver::bench_resolver_memory

+4%

510.4 µs490.2 µs

medium

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+1%

18 µs17.8 µs

small

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+1%

11.5 µs11.4 µs

complex_real

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+1%

23.8 µs23.6 µs

large

benches/resolver.rs::resolver::bench_package_json_deserialization::package_json_deserialization

+1%

28 µs27.8 µs

resolver_real[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_real

60.8 ms60.6 ms

resolver_real[single-thread]

benches/resolver.rs::resolver::bench_resolver_real

494.8 µs494.5 µs

resolver_real[multi-thread]

benches/resolver.rs::resolver::bench_resolver_real

512.3 µs512.5 µs

resolver_memory[single-thread]

benches/resolver.rs::resolver::bench_resolver_memory

497.8 µs499.1 µs

resolver_memory[resolve from symlinks]

benches/resolver.rs::resolver::bench_resolver_memory

-1%

60.5 ms60.9 ms

Commits

Click on a commit to change the comparison range

Base

main

c957d95

+0.7%

fix: skip loading tsconfig.json from virtual module paths (#809) refs #758 fixes, https://github.com/vitejs/rolldown-vite/issues/477 The tests passes without the change, but covers the new `if`. To make a test that fails, we need to configure the cwd to a different path, but that makes the test more complex, so I didn't do that.

7ea7e65

7 days ago

by sapphi-red

Home Terms Privacy Docs