fix/preserve-newlines-in-comments - Branch - oxc-project/json-strip-comments

fix: preserve newlines in block comments to match JavaScript behavior

#120

Comparing

fix/preserve-newlines-in-comments

(

5d255b2

) with

main

(

eab81e0

)

-19%

Regressions: 4

Benchmarks

Failed

minimal_comments

benches/strip.rs::strip::bench

Regression

-19%

2.4 µs3 µs

tsconfig

benches/strip.rs::strip::bench

Regression

-10%

19.2 µs21.4 µs

large_with_comments

benches/strip.rs::strip::bench

Regression

-15%

58.2 µs68.5 µs

no_comments

benches/strip.rs::strip::bench

Regression

-9%

3.9 µs4.3 µs

Commits

Click on a commit to change the comparison range

Base

main

eab81e0

-18.07%

fix: preserve newlines in block comments to match JavaScript behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

f40d55a

1 day ago

by Boshen

-0.8%

perf: optimize newline preservation using memchr Replace byte-by-byte loops with efficient chunked filling: - Use memchr::memchr2 to find newline positions - Fill spaces in chunks between newlines using optimized fill() - Preserves correctness while restoring performance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

5d255b2

1 day ago

by Boshen

Home Terms Privacy Docs