may-202512-parameters-deprecation-fix - Branch - opsmill/infrahub

Fix false deprecation warnings for parameters in TextAttributeSchema

#7996

Comparing

may-202512-parameters-deprecation-fix

(

f595820

) with

stable

(

8634648

)

-93%

Improvements: 1

Regressions: 1

Untouched: 10

Benchmarks

Failed

test_relationshipmanager_getpeer

backend/tests/benchmark/test_nodemanager_peers.py

Regression

-93%

159.9 µs2,311 µs

Improved

test_graphql_generate_schema

backend/tests/benchmark/test_graphql_generate_schema.py

+28%

497.6 ms388.2 ms

Passed

test_query_rel_one

backend/tests/benchmark/test_graphql_query.py

+3%

661.9 ms639.6 ms

test_query_rel_many

backend/tests/benchmark/test_graphql_query.py

+1%

692.6 ms682.6 ms

test_query_one_model

backend/tests/benchmark/test_graphql_query.py

463.9 ms461.8 ms

test_schemabranch_duplicate

backend/tests/benchmark/test_schemabranch_duplicate.py

-1%

7.2 ms7.3 ms

test_get_menu

backend/tests/benchmark/test_get_menu.py

-3%

246.2 ms253.3 ms

test_load_node_to_db_node_schema

backend/tests/benchmark/test_load_node_to_db.py

-4%

66.9 ms69.4 ms

test_schemabranch_process

backend/tests/benchmark/test_schemabranch_process.py

-4%

1 s1.1 s

test_get_schema

backend/tests/benchmark/test_get_schema.py

-6%

323.7 ms342.6 ms

test_nodemanager_querypeers

backend/tests/benchmark/test_nodemanager_peers.py

-6%

1.5 ms1.6 ms

test_base_schema_duplicate_CoreProposedChange

backend/tests/benchmark/test_nodeschema_duplicate.py

-9%

2.1 ms2.4 ms

Commits

Click on a commit to change the comparison range

Base

stable

8634648

-93.07%

Fix false deprecation warnings for parameters in TextAttributeSchema When loading schemas with min_length, max_length, or regex correctly defined in the parameters block, the system was incorrectly generating deprecation warnings. This happened because reconcile_parameters syncs values between top-level and parameters fields, making it impossible to distinguish the original source. The fix: - Track deprecated field usage in _deprecated_fields_used set during reconcile_parameters when values are synced FROM top-level TO parameters - Update gather_warnings to check this set instead of comparing field values - Add tests to verify no warnings when using parameters correctly Fixes #7995

50753f3

14 hours ago

by FragmentedPacket

-0.01%

Use PrivateAttr for mutable default and add type annotation - Replace mutable class-level set() with PrivateAttr(default_factory=set) to ensure each instance gets its own set - Add type annotation for deprecated_fields to satisfy mypy - Sort deprecated fields for consistent warning order

f595820

14 hours ago

by FragmentedPacket

Home Terms Privacy Docs