fac-fix-nullable-rels-7853 - Branch - opsmill/infrahub

fix(backend): do not delete rels when previewing mutation object

#7854

Comparing

fac-fix-nullable-rels-7853

(

9a9eb42

) with

stable

(

0084f44

)

-93%

Regressions: 1

Untouched: 11

No successful run was found on stable ( 1715921) during the generation of this report, so 87d2c56 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Failed

test_relationshipmanager_getpeer

backend/tests/benchmark/test_nodemanager_peers.py

Regression

-93%

166.9 µs2,320.5 µs

Passed

test_query_one_model

backend/tests/benchmark/test_graphql_query.py

+4%

481.9 ms464.5 ms

test_query_rel_one

backend/tests/benchmark/test_graphql_query.py

+4%

665.9 ms642.4 ms

test_get_menu

backend/tests/benchmark/test_get_menu.py

+3%

261.3 ms254.9 ms

test_query_rel_many

backend/tests/benchmark/test_graphql_query.py

+2%

702.7 ms687.4 ms

test_base_schema_duplicate_CoreProposedChange

backend/tests/benchmark/test_nodeschema_duplicate.py

2.2 ms2.2 ms

test_schemabranch_duplicate

backend/tests/benchmark/test_schemabranch_duplicate.py

7.3 ms7.3 ms

test_graphql_generate_schema

backend/tests/benchmark/test_graphql_generate_schema.py

-1%

389.1 ms392.1 ms

test_schemabranch_process

backend/tests/benchmark/test_schemabranch_process.py

-1%

1 s1 s

test_get_schema

backend/tests/benchmark/test_get_schema.py

-1%

342.4 ms346.4 ms

test_load_node_to_db_node_schema

backend/tests/benchmark/test_load_node_to_db.py

-2%

68.6 ms69.7 ms

test_nodemanager_querypeers

backend/tests/benchmark/test_nodemanager_peers.py

-6%

1.6 ms1.7 ms

Commits

Click on a commit to change the comparison range

Base

stable

0084f44

-92.81%

fix(backend): do not delete rels when previewing mutation object PR #7508 introduced a regression where relationship constraints would not rollback the transaction in case of failures due to the introduction of a "preview object" executed outside of the transaction. This would leave objects with nulled relationships where it would not have been allowed. Make sure those deletions are not processed when building this preview object. Also add more coverage to the unit test. Fixes #7853 Signed-off-by: Fatih Acar <fatih@opsmill.com>

9a9eb42

4 hours ago

by fatih-acar

Home Terms Privacy Docs