fix: reject generic deletions referenced by inherit_from and roll back failed schema updates (closes #8988)
#8991MergedComparing
ai-bug-pipeline-8988-inherit-from-deletion-validation
(3f6b869
) withstable
(a5cfbe0
)+3%
- Untouched
- 12
No successful run was found on stable ( 349ee8e) during the generation of this report, so 292ac42 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.
Benchmarks
12 total
test_schemabranch_process
backend/tests/benchmark/test_schemabranch_process.py+8%
1.6 s1.4 s
test_get_schema
backend/tests/benchmark/test_get_schema.py+5%
346.1 ms328.1 ms
test_schemabranch_duplicate
backend/tests/benchmark/test_schemabranch_duplicate.py+5%
7.6 ms7.2 ms
test_load_node_to_db_node_schema
backend/tests/benchmark/test_load_node_to_db.py+5%
69.7 ms66.7 ms
test_graphql_generate_schema
backend/tests/benchmark/test_graphql_generate_schema.py+3%
529.4 ms514.7 ms
test_base_schema_duplicate_CoreProposedChange
backend/tests/benchmark/test_nodeschema_duplicate.py+3%
2.1 ms2.1 ms
test_query_rel_one
backend/tests/benchmark/test_graphql_query.py0%
663.2 ms660.3 ms
test_query_one_model
backend/tests/benchmark/test_graphql_query.py0%
464.5 ms462.7 ms
test_query_rel_many
backend/tests/benchmark/test_graphql_query.py0%
694.5 ms691.8 ms
test_nodemanager_querypeers
backend/tests/benchmark/test_nodemanager_peers.py0%
1.5 ms1.5 ms
test_relationshipmanager_getpeer
backend/tests/benchmark/test_nodemanager_peers.py0%
156.9 µs156.9 µs
Commits
Click on a commit to change the comparison rangeBase
stable
a5cfbe0
+2.76%
test: add failing rollback test for #8988
597af0b
15 hours ago
by polmichel-0.04%
refactor: restructure execute() tail so ruff RET503 is happy
e08c25d
14 hours ago
by polmichel-0.22%
fix: guard inherit_from check against GenericSchema in validate_node_deletions
fd57a9a
14 hours ago
by polmichel+0.15%
reducing verbosity of comments
040d19a
14 hours ago
by polmichel-0.03%
edge case: generic node and inheriting nodes were deleted in the same schema update
ef5817a
13 hours ago
by polmichel+0.16%
update tests so that they reflect the real production code path
3f6b869
3 hours ago
by polmichel