feat/task-33-detect-duplicates - Branch - mpiton/vortex

refactor(link): tighten task-33 duplicate detection per code review

#145Merged

Comparing

feat/task-33-detect-duplicates

(

c216cff

) with

main

(

1c783c0

)

-23%

Improvement: 1

Regression: 4

Untouched: 21

Benchmarks

26 total

from_status_code_200

src-tauri/benches/domain_benchmarks.rs::benches::bench_link_status::link_status

+31%

123.1 ns93.9 ns

full_lifecycle

src-tauri/benches/domain_benchmarks.rs::benches::bench_segment_operations::segment_operations

-11%

225.6 ns254.7 ns

split

src-tauri/benches/domain_benchmarks.rs::benches::bench_segment_operations::segment_operations

-11%

471.9 ns530.3 ns

reject_invalid

src-tauri/benches/domain_benchmarks.rs::benches::bench_checksum_detection::checksum_detection

-15%

493.6 ns581.1 ns

from_status_code_500

src-tauri/benches/domain_benchmarks.rs::benches::bench_link_status::link_status

-23%

96.1 ns125.3 ns

with_userinfo

src-tauri/benches/domain_benchmarks.rs::benches::bench_url_parsing::url_parsing

+4%

2.6 µs2.5 µs

complex_with_port_and_path

src-tauri/benches/domain_benchmarks.rs::benches::bench_url_parsing::url_parsing

+2%

2.6 µs2.6 µs

create_new

src-tauri/benches/domain_benchmarks.rs::benches::bench_download_state_machine::download_state_machine

+2%

4.8 µs4.8 µs

apply_patch_many_fields

src-tauri/benches/domain_benchmarks.rs::benches::bench_config_operations::config_operations

+2%

3.7 µs3.6 µs

simple_https

src-tauri/benches/domain_benchmarks.rs::benches::bench_url_parsing::url_parsing

+1%

2.4 µs2.4 µs

apply_patch_single_field

src-tauri/benches/domain_benchmarks.rs::benches::bench_config_operations::config_operations

+1%

3 µs2.9 µs

default_config

src-tauri/benches/domain_benchmarks.rs::benches::bench_config_operations::config_operations

+1%

3.2 µs3.2 µs

checksum_workflow

src-tauri/benches/domain_benchmarks.rs::benches::bench_download_state_machine::download_state_machine

6.3 µs6.3 µs

create_invalid

src-tauri/benches/domain_benchmarks.rs::benches::bench_priority::priority

2.6 µs2.6 µs

normalize_max_concurrent

src-tauri/benches/domain_benchmarks.rs::benches::bench_config_operations::config_operations

150 ns150 ns

progress_percentage

src-tauri/benches/domain_benchmarks.rs::benches::bench_download_state_machine::download_state_machine

423.1 ns423.1 ns

start_and_fail_retry_cycle

src-tauri/benches/domain_benchmarks.rs::benches::bench_download_state_machine::download_state_machine

4.8 µs4.8 µs

normalize_link_check_parallelism

src-tauri/benches/domain_benchmarks.rs::benches::bench_config_operations::config_operations

150 ns150 ns

create_valid

src-tauri/benches/domain_benchmarks.rs::benches::bench_priority::priority

312.5 ns312.5 ns

ftp_scheme

src-tauri/benches/domain_benchmarks.rs::benches::bench_url_parsing::url_parsing

2.5 µs2.5 µs

from_status_code_404

src-tauri/benches/domain_benchmarks.rs::benches::bench_link_status::link_status

154.7 ns154.7 ns

detect_sha256

src-tauri/benches/domain_benchmarks.rs::benches::bench_checksum_detection::checksum_detection

763.6 ns763.6 ns

full_lifecycle

src-tauri/benches/domain_benchmarks.rs::benches::bench_download_state_machine::download_state_machine

-1%

3.9 µs3.9 µs

error_and_reset_cycle

src-tauri/benches/domain_benchmarks.rs::benches::bench_segment_operations::segment_operations

-2%

1.6 µs1.7 µs

detect_md5

src-tauri/benches/domain_benchmarks.rs::benches::bench_checksum_detection::checksum_detection

-9%

599.2 ns657.5 ns

Commits

Click on a commit to change the comparison range

Base

main

1c783c0

+0.24%

refactor(link): tighten task-33 duplicate detection per code review

25076e6

14 hours ago

by mpiton

-23.53%

fix(link): address PR #145 review comments

ec352ca

4 hours ago

by mpiton

fix(link): unblock bulk start when duplicate detection IPC fails

6b62033

3 hours ago

by mpiton

fix(link): unify URL identity for dedupe and start

65b35b3

2 hours ago

by mpiton

fix(link): collapse bulk starts by canonical URL

a5a3846

2 hours ago

by mpiton

fix(link): dedupe probe inputs without indexing on originalUrl

c216cff

2 hours ago

by mpiton

Home Terms Privacy Docs