fix(taps): Hard and soft deletes for handling `ACTIVATE_VERSION` messages now use the same `WHERE` clause
#2242MergedComparing
techindicium:fix/use-same-logic-for-both-hard-and-soft-delete
(c20f87c
) withmain
(2de41df
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 6
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
test_bench_deserialize_json
tests/core/test_io.py::test_bench_deserialize_json+1%
23.4 ms
23.1 ms
test_bench_validate_record_with_schema
tests/core/sinks/test_validation.py::test_bench_validate_record_with_schema0%
114.3 ms
113.8 ms
test_bench_validate_and_parse
tests/core/sinks/test_validation.py::test_bench_validate_and_parse0%
126.6 ms
126.5 ms
test_bench_format_message
tests/core/test_io.py::test_bench_format_message0%
52 ms
52 ms
test_bench_simple_map_transforms
tests/core/test_mapper.py::test_bench_simple_map_transforms0%
642.8 ms
642.4 ms
test_bench_parse_timestamps_in_record
tests/core/sinks/test_validation.py::test_bench_parse_timestamps_in_record0%
11.4 ms
11.4 ms
Commits
Click on a commit to change the comparison rangeBase
main
2de41df
0%
fix: using same logic for both hard and soft deletes
Soft delete is deleting only versions smaller than the latest version
Hard delete is deleting smaller and equal.
Making both strategies delete only smaller versions.
c20f87c
1 year ago
by vitoravancini