fix(targets): Quote add-column-ddl with column starting with `_` (underscore) based on engine
#2583MergedComparing
haleemur:fix-add-column-quoting
(2676bc4
) withmain
(278fde4
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 6
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
test_bench_validate_record_with_schema
tests/core/sinks/test_validation.py::test_bench_validate_record_with_schema0%
112.2 ms
111.9 ms
test_bench_parse_timestamps_in_record
tests/core/sinks/test_validation.py::test_bench_parse_timestamps_in_record0%
11.5 ms
11.5 ms
test_bench_simple_map_transforms
tests/core/test_mapper.py::test_bench_simple_map_transforms0%
645.2 ms
644.2 ms
test_bench_validate_and_parse
tests/core/sinks/test_validation.py::test_bench_validate_and_parse0%
125 ms
124.9 ms
test_bench_format_message
tests/core/test_io.py::test_bench_format_message0%
53.4 ms
53.4 ms
test_bench_deserialize_json
tests/core/test_io.py::test_bench_deserialize_json0%
24.2 ms
24.3 ms
Commits
Click on a commit to change the comparison rangeBase
main
278fde4
0%
fix column quoting and add tests
b505697
5 months ago
by haleemur0%
remove mypy ignore
e30c08d
5 months ago
by haleemur0%
Merge branch 'main' into fix-add-column-quoting
2676bc4
5 months ago
by edgarrmondragon