BuzzCutNorman:1677-fix-do-not-use-start-date-with-non-date-columns - Branch - meltano/sdk

fix: Check if replication key is timestamp before using start_date as default

#1734

Comparing

BuzzCutNorman:1677-fix-do-not-use-start-date-with-non-date-columns

(

6a6f850

) with

main

(

cb163bf

)

Untouched: 6

Benchmarks

Passed

test_bench_validate_and_parse

tests/core/sinks/test_validation.py

125.4 ms124.9 ms

test_bench_parse_timestamps_in_record

tests/core/sinks/test_validation.py

11.5 ms11.4 ms

test_bench_validate_record_with_schema

tests/core/sinks/test_validation.py

112.5 ms112.2 ms

test_bench_format_message

tests/core/test_io.py

53.5 ms53.4 ms

test_bench_simple_map_transforms

tests/core/test_mapper.py

644.2 ms644.4 ms

test_bench_deserialize_json

tests/core/test_io.py

-3%

24.1 ms25 ms

Commits

Click on a commit to change the comparison range

Base

main

cb163bf

-0.26%

Merge branch 'main' into 1677-fix-do-not-use-start-date-with-non-date-columns

0df7421

1 year ago

by edgarrmondragon

-0.06%

Merge branch 'main' into 1677-fix-do-not-use-start-date-with-non-date-columns

86ce7a2

1 year ago

by edgarrmondragon

-0.06%

Merge branch 'main' into 1677-fix-do-not-use-start-date-with-non-date-columns

6a6f850

1 year ago

by BuzzCutNorman

Home Terms Privacy Docs