bnjbvr/sending-no-network-isnt-error - Branch - matrix-org/matrix-rust-sdk

fix(latest event): mark a recoverable failure to send as a sending item

#6016Merged

Comparing

bnjbvr/sending-no-network-isnt-error

(

3364225

) with

main

(

b1ca2bb

)

Untouched: 50

Benchmarks

Passed

Linked chunk lazy loader[sqlite store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

+4%

411 µs396.6 µs

Linked chunk metadata loader[memory store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

+2%

5.8 µs5.7 µs

Event cache find_event_relations[SQLite][10 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

+1%

964.2 µs957.9 µs

Linked chunk metadata loader[sqlite store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

+1%

156.3 µs155.3 µs

Linked chunk metadata loader[sqlite store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

1.2 ms1.1 ms

Devices collecting [SQLite][2003 devices]

benchmarks/benches/crypto_bench.rs::benches::devices_missing_sessions_collecting::Devices missing sessions collecting

99.5 ms99 ms

Linked chunk writing [sqlite store][100]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

3 ms3 ms

Event cache room updates[memory][room count: 10]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

155 ms154.5 ms

Linked chunk writing [sqlite store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

33.3 ms33.2 ms

Room key sharing [SQLite][163 devices]

benchmarks/benches/crypto_bench.rs::benches::room_key_sharing::Room key sharing

57.4 ms57.2 ms

Linked chunk lazy loader[sqlite store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

15.1 ms15 ms

Linked chunk lazy loader[memory store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

34 µs33.9 µs

Event cache room updates[SQLite][room count: 10]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

458.5 ms457.5 ms

Room key sharing [memory][163 devices]

benchmarks/benches/crypto_bench.rs::benches::room_key_sharing::Room key sharing

46.9 ms46.8 ms

Linked chunk metadata loader[memory store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

19.9 µs19.8 µs

Linked chunk lazy loader[sqlite store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

1.7 ms1.7 ms

Event cache find_event_relations[SQLite][1000 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

72.3 ms72.3 ms

Event cache room updates[SQLite][room count: 100]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

4.9 s4.9 s

Restore session [memory store]

benchmarks/benches/store_bench.rs::benches::restore_session::Client reload

268.1 ms268 ms

Restore session [SQLite][encrypted]

benchmarks/benches/store_bench.rs::benches::restore_session::Client reload

1.3 s1.3 s

Linked chunk writing [none][100]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

89 µs88.9 µs

Event cache find_event_relations[memory][10 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

3.2 ms3.2 ms

Linked chunk writing [none][1000]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

832.9 µs832.6 µs

Event cache find_event_relations[memory][10 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

3.2 ms3.2 ms

Event cache find_event_relations[memory][100 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

45.5 ms45.5 ms

Event cache find_event_relations[memory][1000 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

2.2 s2.2 s

Restore session [SQLite][clear]

benchmarks/benches/store_bench.rs::benches::restore_session::Client reload

713.9 ms713.8 ms

Event cache find_event_relations[memory][1000 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

2.2 s2.2 s

Event cache find_event_relations[memory][100 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

45.5 ms45.5 ms

Linked chunk writing [sqlite store][10]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

585.8 µs585.8 µs

Linked chunk writing [none][10]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

16 µs16 µs

Devices collecting [memory][2003 devices]

benchmarks/benches/crypto_bench.rs::benches::devices_missing_sessions_collecting::Devices missing sessions collecting

10.8 ms10.8 ms

Linked chunk writing [memory store][10]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

52.4 µs52.4 µs

Device keys query [memory][153 device and cross signing keys]

benchmarks/benches/crypto_bench.rs::benches::keys_query::Keys querying

27.5 ms27.5 ms

Linked chunk writing [memory store][100]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

353.9 µs354.2 µs

Linked chunk metadata loader[memory store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

679.2 µs679.7 µs

Linked chunk lazy loader[memory store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

2.4 ms2.4 ms

Event cache find_event_relations[SQLite][10 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

902.5 µs903.3 µs

Event cache room updates[SQLite][room count: 1]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

42.9 ms43 ms

Linked chunk metadata loader[sqlite store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

227.9 µs228.2 µs

Device keys query [SQLite][153 device and cross signing keys]

benchmarks/benches/crypto_bench.rs::benches::keys_query::Keys querying

38.7 ms38.8 ms

Event cache find_event_relations[SQLite][1000 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

67.7 ms67.8 ms

Event cache room updates[memory][room count: 1]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

15.4 ms15.5 ms

Linked chunk lazy loader[memory store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

191.7 µs192.2 µs

Event cache room updates[memory][room count: 100]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

1.6 s1.6 s

Event cache find_event_relations[SQLite][100 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

-1%

7.4 ms7.4 ms

Linked chunk writing [memory store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

-1%

3.5 ms3.5 ms

Event cache find_event_relations[SQLite][100 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

-1%

6.9 ms7 ms

Create[1000 rooms × 1000 events]

benchmarks/benches/room_list.rs::room_list::create::RoomList

-2%

6 ms6.2 ms

Create a timeline with initial events[10000 events]

benchmarks/benches/timeline.rs::room::create_timeline_with_initial_events::Create a timeline

-2%

731.1 ms745.6 ms

Commits

Click on a commit to change the comparison range

Base

main

b1ca2bb

+0.03%

fix(latest event): mark a failed but recoverable attempt to send as a sending In the send queue, failures to send can be classified into two categories: - permanent failures (e.g. invalid parameters) - recoverable failures (e.g. network is down; server responded with a transient error code) The latest event system would classify all the failures as "cannot be sent", which is slightly incorrect if the failure was recoverable. In this case, we should still consider the local event as being sent, as the system should try to send it some time soon.

3364225

1 day ago

by bnjbvr

Home Terms Privacy Docs