andybalaam/improve-decryption-failure-log-wording - Branch - matrix-org/matrix-rust-sdk

Improve the wording of error messages when redecryption fails

#5861Merged

Comparing

andybalaam/improve-decryption-failure-log-wording

(

65c05ad

) with

main

(

a3424a7

)

Untouched: 50

Benchmarks

Passed

Devices collecting [memory][2003 devices]

benchmarks/benches/crypto_bench.rs::benches::devices_missing_sessions_collecting::Devices missing sessions collecting

+4%

10.8 ms10.4 ms

Linked chunk writing [memory store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

+3%

3.7 ms3.6 ms

Event cache find_event_relations[SQLite][10 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

+2%

1.2 ms1.2 ms

Linked chunk writing [memory store][100]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

+1%

364.2 µs359.5 µs

Linked chunk metadata loader[memory store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

+1%

5.7 µs5.6 µs

Event cache find_event_relations[SQLite][1000 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

+1%

72.2 ms71.6 ms

Event cache find_event_relations[SQLite][10 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

+1%

1.1 ms1.1 ms

Linked chunk lazy loader[sqlite store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

+1%

15.5 ms15.4 ms

Room key sharing [SQLite][163 devices]

benchmarks/benches/crypto_bench.rs::benches::room_key_sharing::Room key sharing

58 ms57.7 ms

Device keys query [SQLite][153 device and cross signing keys]

benchmarks/benches/crypto_bench.rs::benches::keys_query::Keys querying

39 ms39 ms

Devices collecting [SQLite][2003 devices]

benchmarks/benches/crypto_bench.rs::benches::devices_missing_sessions_collecting::Devices missing sessions collecting

100.5 ms100.3 ms

Linked chunk lazy loader[sqlite store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

1.7 ms1.7 ms

Linked chunk writing [none][10]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

15.8 µs15.8 µs

Linked chunk metadata loader[sqlite store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

229.7 µs229.3 µs

Device keys query [memory][153 device and cross signing keys]

benchmarks/benches/crypto_bench.rs::benches::keys_query::Keys querying

27.6 ms27.6 ms

Event cache room updates[memory][room count: 1]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

14.1 ms14.1 ms

Linked chunk lazy loader[memory store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

192.4 µs192.1 µs

Linked chunk lazy loader[memory store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

2.4 ms2.4 ms

Event cache room updates[memory][room count: 10]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

143.5 ms143.4 ms

Event cache room updates[SQLite][room count: 100]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

4.7 s4.7 s

Event cache find_event_relations[SQLite][100 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

8 ms7.9 ms

Create[1000 rooms × 1000 events]

benchmarks/benches/room_list.rs::room_list::create::RoomList

30.7 ms30.7 ms

Event cache find_event_relations[memory][1000 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

2.2 s2.2 s

Event cache find_event_relations[memory][1000 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

2.2 s2.2 s

Linked chunk writing [none][100]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

87.8 µs87.8 µs

Event cache find_event_relations[memory][10 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

3.3 ms3.3 ms

Event cache find_event_relations[memory][10 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

3.3 ms3.3 ms

Event cache find_event_relations[memory][100 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

46.9 ms46.9 ms

Event cache find_event_relations[memory][100 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

46.9 ms46.9 ms

Linked chunk writing [sqlite store][100]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

3 ms3 ms

Room key sharing [memory][163 devices]

benchmarks/benches/crypto_bench.rs::benches::room_key_sharing::Room key sharing

46.8 ms46.9 ms

Restore session [memory store]

benchmarks/benches/store_bench.rs::benches::restore_session::Client reload

274.5 ms274.6 ms

Linked chunk metadata loader[memory store][100]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

19.8 µs19.8 µs

Linked chunk metadata loader[sqlite store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

1.1 ms1.1 ms

Event cache room updates[SQLite][room count: 10]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

444.4 ms444.8 ms

Linked chunk writing [none][1000]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

822.9 µs823.6 µs

Restore session [SQLite][encrypted]

benchmarks/benches/store_bench.rs::benches::restore_session::Client reload

1.4 s1.4 s

Linked chunk writing [sqlite store][10]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

586.2 µs586.7 µs

Linked chunk writing [sqlite store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

33.3 ms33.3 ms

Linked chunk metadata loader[memory store][1000]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

677.1 µs677.9 µs

Restore session [SQLite][clear]

benchmarks/benches/store_bench.rs::benches::restore_session::Client reload

749.2 ms750.2 ms

Event cache find_event_relations[SQLite][100 events, #no filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

7.5 ms7.5 ms

Event cache room updates[SQLite][room count: 1]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

42 ms42.1 ms

Event cache room updates[memory][room count: 100]

benchmarks/benches/event_cache.rs::event_cache::handle_room_updates::Event cache room updates

1.5 s1.5 s

Create a timeline with initial events[10000 events]

benchmarks/benches/timeline.rs::room::create_timeline_with_initial_events::Create a timeline

-1%

725.5 ms729.4 ms

Linked chunk lazy loader[sqlite store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

-1%

402.2 µs404.7 µs

Event cache find_event_relations[SQLite][1000 events, edits filter]

benchmarks/benches/event_cache.rs::event_cache::find_event_relations::Event cache room updates

-1%

76.6 ms77.2 ms

Linked chunk metadata loader[sqlite store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

-1%

156.4 µs157.9 µs

Linked chunk writing [memory store][10]

benchmarks/benches/linked_chunk.rs::event_cache::writing::Linked chunk writing

-1%

52.1 µs52.7 µs

Linked chunk lazy loader[memory store][10]

benchmarks/benches/linked_chunk.rs::event_cache::reading::Linked chunk reading

-2%

33.2 µs33.9 µs

Commits

Click on a commit to change the comparison range

Base

main

a3424a7

+0.14%

Improve the wording of error messages when redecryption fails The previous message implied that we had received a session for this message, but that is only one of the several reasons we might encounter this situation. If redecryption failed, it is more likely we got here because we'd been asked to attempt redecryption for all UTDs e.g. when we build a new timeline. Additionally, having similar wording for the error case and the unable to decrypt case could also cause confusion, so I adjusted the wording to make clear which situation is happening.

65c05ad

1 day ago

by andybalaam

Home Terms Privacy Docs