philnash:multipart-boundary-end - Branch - langflow-ai/langflow

fix: allow multipart/form-data boundary to end with a newline

#5660Merged

Comparing

philnash:multipart-boundary-end

(

08fd912

) with

main

(

e7a2005

)

+33%

Improvements: 2

Untouched: 13

Benchmarks

Improved

test_successful_run_with_input_type_any

src/backend/tests/unit/test_endpoints.py

+33%

339.5 ms255.8 ms

test_successful_run_with_output_type_debug

src/backend/tests/unit/test_endpoints.py

+11%

277.6 ms251.2 ms

Passed

test_successful_run_with_input_type_text

src/backend/tests/unit/test_endpoints.py

250.3 ms249.2 ms

test_setup_llm_caching

src/backend/tests/performance/test_server_init.py

958.6 µs955.7 µs

test_get_all

src/backend/tests/unit/test_endpoints.py

466.8 ms466.2 ms

test_invalid_run_with_input_type_chat

src/backend/tests/unit/test_endpoints.py

29.7 ms29.7 ms

test_starter_projects

src/backend/tests/unit/test_endpoints.py

1.1 s1.1 s

test_initialize_services

src/backend/tests/performance/test_server_init.py

154.9 ms155 ms

test_create_starter_projects

src/backend/tests/performance/test_server_init.py

1.1 s1.1 s

test_successful_run_with_output_type_any

src/backend/tests/unit/test_endpoints.py

240 ms240.5 ms

test_load_flows

src/backend/tests/performance/test_server_init.py

1 ms1 ms

test_initialize_super_user

src/backend/tests/performance/test_server_init.py

159.4 ms159.8 ms

test_build_flow_from_request_data

src/backend/tests/unit/test_chat_endpoint.py

416 ms417.6 ms

test_build_flow

src/backend/tests/unit/test_chat_endpoint.py

401.4 ms402.9 ms

test_get_and_cache_all_types_dict

src/backend/tests/performance/test_server_init.py

-1%

1.1 ms1.1 ms

Commits

Click on a commit to change the comparison range

Base

main

e7a2005

+32.73%

fix: allow multipart/form-data boundary to end with a newline The RFC 7578 spec for multipart/form-data requests does not require the body of a request to end with a CRLF, only that each section begins with a CRLF. While many clients implement multipart requests with the trailing CRLF, the implementation for fetch in Node.js version 22 and below does not. This caused my a good number of hours debugging! It does turn out that in September 2024 the Node.js fetch implementation added the CRLF (https://github.com/nodejs/undici/pull/3625), though this hasn't made it to a Node.js release yet. This change allows the boundary to end with a newline or not, as long as the boundary is followed by the end of the request body.

08fd912

10 months ago

by philnash

Home Terms Privacy Docs