fixManyMessageErrors - Branch - langflow-ai/langflow

fix: Improve error handling in aupdate_messages function to prevent empty message error

#5655Merged

Comparing

fixManyMessageErrors

(

d6cb281

) with

main

(

a955951

)

×15

Improvements: 2

Regressions: 0

Untouched: 13

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Improved

test_successful_run_with_input_type_text

src/backend/tests/unit/test_endpoints.py::test_successful_run_with_input_type_text

×15

4,228.4 ms

289.8 ms

test_successful_run_with_input_type_any

src/backend/tests/unit/test_endpoints.py::test_successful_run_with_input_type_any

+32%

347.6 ms

262.4 ms

Passed

test_build_flow

src/backend/tests/unit/test_chat_endpoint.py::test_build_flow

+2%

412.8 ms

404.6 ms

test_successful_run_with_output_type_any

src/backend/tests/unit/test_endpoints.py::test_successful_run_with_output_type_any

+1%

248.3 ms

244.7 ms

test_get_and_cache_all_types_dict

src/backend/tests/performance/test_server_init.py::test_get_and_cache_all_types_dict

+1%

1,000.3 µs

986.5 µs

test_build_flow_from_request_data

src/backend/tests/unit/test_chat_endpoint.py::test_build_flow_from_request_data

+1%

424.9 ms

421 ms

test_initialize_services

src/backend/tests/performance/test_server_init.py::test_initialize_services

+1%

155.5 ms

154.7 ms

test_setup_llm_caching

src/backend/tests/performance/test_server_init.py::test_setup_llm_caching

962.2 µs

959 µs

test_get_all

src/backend/tests/unit/test_endpoints.py::test_get_all

501.8 ms

500.3 ms

test_create_starter_projects

src/backend/tests/performance/test_server_init.py::test_create_starter_projects

1.1 s

test_starter_projects

src/backend/tests/unit/test_endpoints.py::test_starter_projects

1.1 s

test_initialize_super_user

src/backend/tests/performance/test_server_init.py::test_initialize_super_user

159.5 ms

159.6 ms

test_load_flows

src/backend/tests/performance/test_server_init.py::test_load_flows

1.1 ms

test_successful_run_with_output_type_debug

src/backend/tests/unit/test_endpoints.py::test_successful_run_with_output_type_debug

-1%

257.6 ms

259.5 ms

test_invalid_run_with_input_type_chat

src/backend/tests/unit/test_endpoints.py::test_invalid_run_with_input_type_chat

-3%

29.1 ms

29.9 ms

Commits

Click on a commit to change the comparison range

Base

main

a955951

-33%

fix(tests): updating a non-existing message adds a new message now - Updated the test name from `test_aupdate_nonexistent_message` to `test_aupdate_nonexistent_message_generates_a_new_message` for better clarity. - Modified the assertion to expect that a new message is generated when attempting to update a nonexistent message, changing the expected length of the updated messages from 0 to 1.

6aaedff

5 months ago

by ogabrielluiz

+120%

[autofix.ci] apply automated fixes

a447f87

5 months ago

by autofix-ci[bot]

+1,272%

fix(tests): update message handling in tests for non-existent messages - Refactored tests to ensure that attempting to update a non-existent message raises a ValueError instead of creating a new message. - Updated test names and assertions for clarity and accuracy, ensuring they reflect the expected behavior when handling messages that do not exist in the database.

d6cb281

5 months ago

by ogabrielluiz

Home Terms Privacy Docs