keyuchen21:fix-chat-prompt-save - Branch - langchain-ai/langchain

fix(core): implement `ChatPromptTemplate.save()` method

#32654Closed

Comparing

keyuchen21:fix-chat-prompt-save

(

abdb539

) with

master

(

2d0713c

)

Untouched: 14

This report only contains results for the CPU Simulation instrument. To view results for the Wall Time instrument, click here.

Benchmarks

Passed

test_init_time

libs/partners/anthropic/tests/unit_tests/test_standard.py::TestAnthropicStandard

3.8 ms3.8 ms

test_stream_time

libs/partners/anthropic/tests/integration_tests/test_standard.py::TestAnthropicStandard

37.5 ms37.4 ms

test_stream_time

libs/partners/openai/tests/integration_tests/chat_models/test_responses_standard.py::TestOpenAIStandard

1.1 s1.1 s

test_stream_time

libs/partners/openai/tests/integration_tests/chat_models/test_base_standard.py::TestOpenAIStandard

1.1 s1.1 s

test_stream_time

libs/partners/openai/tests/integration_tests/chat_models/test_responses_standard.py::TestOpenAIResponses

935.5 ms935.1 ms

test_init_time

libs/partners/mistralai/tests/unit_tests/test_standard.py::TestMistralStandard

12.5 ms12.5 ms

test_init_time

libs/partners/deepseek/tests/unit_tests/test_chat_models.py::TestChatDeepSeekUnit

1.6 s1.6 s

test_init_time

libs/partners/openai/tests/unit_tests/chat_models/test_azure_standard.py::TestOpenAIStandard

1.7 s1.7 s

test_init_time

libs/partners/fireworks/tests/unit_tests/test_standard.py::TestFireworksStandard

6.6 s6.6 s

test_init_time

libs/partners/xai/tests/unit_tests/test_chat_models_standard.py::TestXAIStandard

3.3 s3.3 s

test_init_time

libs/partners/groq/tests/unit_tests/test_standard.py::TestGroqStandard

1.6 s1.6 s

test_init_time_with_client

libs/partners/anthropic/tests/unit_tests/test_standard.py

5.3 ms5.3 ms

test_init_time

libs/partners/openai/tests/unit_tests/chat_models/test_responses_standard.py::TestOpenAIResponses

17.1 ms17.2 ms

test_init_time

libs/partners/openai/tests/unit_tests/chat_models/test_base_standard.py::TestOpenAIStandard

17.1 ms17.1 ms

Commits

Click on a commit to change the comparison range

Base

master

2d0713c

+0.03%

core: fix ChatPromptTemplate.save() implementation - Replace NotImplementedError with working implementation - Use dumpd() for proper serialization to ensure compatibility with load() - Support both JSON and YAML formats - Add comprehensive unit tests for save functionality - Handle error cases (invalid extensions, partial variables) - Ensure directory creation when saving to nested paths Fixes #32637 Co-Authored-By: Keyu <noreply@anthropic.com>

b21a18d

3 months ago

by keyuchen21

fix: resolve linting issues in test_chat.py - Remove trailing whitespace - Remove whitespace in blank lines - Use Path.open() instead of open() for file operations

6cb2c75

3 months ago

by keyuchen21

+1.3%

fix: correct test cases to properly load JSON data - Parse JSON data before passing to load() function - Fix trailing whitespace issues - Tests now correctly verify save/load functionality

ec471e8

3 months ago

by keyuchen21

+2.22%

style: apply ruff formatting to test_chat.py - Add blank line after import statement - Add trailing comma in function arguments - Consolidate single-line ChatPromptTemplate instantiations

abdb539

3 months ago

by keyuchen21

Home Terms Privacy Docs