Avatar for the jvdd user
jvdd
argminmax
BlogDocsChangelog

fix: allow double update in scalar ignore nan implementation

#40Merged
Comparing
scalar_ignore_nan_bug
(
6ba2249
) with
main
(
5034986
)
CodSpeed Performance Gauge
-6%
Improvements
0
Regressions
2
Untouched
50
New
0
Dropped
0
Ignored
0

Benchmarks

Failed

scalar_f32_argminmax_inRegression
benches/bench_f32_ignore_nan.rs::benches::argminmax_in_f32_random_array_long::scalar_f32_argminmax_in
CodSpeed Performance Gauge
-6%
442.9 µs
471.3 µs
scalar_f64_argminmax_inRegression
benches/bench_f64_ignore_nan.rs::benches::argminmax_in_f64_random_array_long::scalar_f64_argminmax_in
CodSpeed Performance Gauge
-4%
629.6 µs
658 µs

Passed

impl_u32_argminmax
benches/bench_u32.rs::benches::argminmax_u32_random_array_long::impl_u32_argminmax
CodSpeed Performance Gauge
0%
225.1 µs
225.1 µs
impl_i32_argminmax
benches/bench_i32.rs::benches::argminmax_i32_random_array_long::impl_i32_argminmax
CodSpeed Performance Gauge
0%
225 µs
225 µs
impl_i64_argminmax
benches/bench_i64.rs::benches::argminmax_i64_random_array_long::impl_i64_argminmax
CodSpeed Performance Gauge
0%
459.5 µs
459.5 µs
sse_i64_argminmax
benches/bench_i64.rs::benches::argminmax_i64_random_array_long::sse_i64_argminmax
CodSpeed Performance Gauge
0%
608.6 µs
608.5 µs
sse_u64_argminmax
benches/bench_u64.rs::benches::argminmax_u64_random_array_long::sse_u64_argminmax
CodSpeed Performance Gauge
0%
622.8 µs
622.8 µs
scalar_f32_argminmax_rn
benches/bench_f32_return_nan.rs::benches::argminmax_rn_f32_random_array_long::scalar_f32_argminmax_rn
CodSpeed Performance Gauge
0%
528.1 µs
528.1 µs
sse_i8_argminmax
benches/bench_i8.rs::benches::argminmax_i8_random_array_long::sse_i8_argminmax
CodSpeed Performance Gauge
0%
85.2 µs
85.2 µs
impl_i8_argminmax
benches/bench_i8.rs::benches::argminmax_i8_random_array_long::impl_i8_argminmax
CodSpeed Performance Gauge
0%
85.3 µs
85.3 µs
sse_u8_argminmax
benches/bench_u8.rs::benches::argminmax_u8_random_array_long::sse_u8_argminmax
CodSpeed Performance Gauge
0%
85.9 µs
85.9 µs
impl_u8_argminmax
benches/bench_u8.rs::benches::argminmax_u8_random_array_long::impl_u8_argminmax
CodSpeed Performance Gauge
0%
86.1 µs
86.1 µs
scalar_u16_argminmax
benches/bench_u16.rs::benches::argminmax_u16_random_array_long::scalar_u16_argminmax
CodSpeed Performance Gauge
0%
349.5 µs
349.5 µs
scalar_i8_argminmax
benches/bench_i8.rs::benches::argminmax_i8_random_array_long::scalar_i8_argminmax
CodSpeed Performance Gauge
0%
359.7 µs
359.7 µs
scalar_u64_argminmax
benches/bench_u64.rs::benches::argminmax_u64_random_array_long::scalar_u64_argminmax
CodSpeed Performance Gauge
0%
629.5 µs
629.5 µs
scalar_i64_argminmax
benches/bench_i64.rs::benches::argminmax_i64_random_array_long::scalar_i64_argminmax
CodSpeed Performance Gauge
0%
629.5 µs
629.5 µs
scalar_u32_argminmax
benches/bench_u32.rs::benches::argminmax_u32_random_array_long::scalar_u32_argminmax
CodSpeed Performance Gauge
0%
442.8 µs
442.8 µs
avx2_u32_argminmax
benches/bench_u32.rs::benches::argminmax_u32_random_array_long::avx2_u32_argminmax
CodSpeed Performance Gauge
0%
224.9 µs
224.9 µs
sse_u32_argminmax
benches/bench_u32.rs::benches::argminmax_u32_random_array_long::sse_u32_argminmax
CodSpeed Performance Gauge
0%
301.2 µs
301.2 µs
sse_f32_argminmax_rn
benches/bench_f32_return_nan.rs::benches::argminmax_rn_f32_random_array_long::sse_f32_argminmax_rn
CodSpeed Performance Gauge
0%
319 µs
319 µs
scalar_i16_argminmax
benches/bench_i16.rs::benches::argminmax_i16_random_array_long::scalar_i16_argminmax
CodSpeed Performance Gauge
0%
349.5 µs
349.5 µs
impl_f64_argminmax_in
benches/bench_f64_ignore_nan.rs::benches::argminmax_in_f64_random_array_long::impl_f64_argminmax_in
CodSpeed Performance Gauge
0%
449.1 µs
449.1 µs
avx2_f64_argminmax_rn
benches/bench_f64_return_nan.rs::benches::argminmax_rn_f64_random_array_long::avx2_f64_argminmax_rn
CodSpeed Performance Gauge
0%
494.9 µs
494.9 µs
impl_f64_argminmax_rn
benches/bench_f64_return_nan.rs::benches::argminmax_rn_f64_random_array_long::impl_f64_argminmax_rn
CodSpeed Performance Gauge
0%
495.1 µs
495.1 µs
sse_f64_argminmax_rn
benches/bench_f64_return_nan.rs::benches::argminmax_rn_f64_random_array_long::sse_f64_argminmax_rn
CodSpeed Performance Gauge
0%
701 µs
701 µs
avx2_i16_argminmax
benches/bench_i16.rs::benches::argminmax_i16_random_array_long::avx2_i16_argminmax
CodSpeed Performance Gauge
0%
113.1 µs
113.1 µs
impl_i16_argminmax
benches/bench_i16.rs::benches::argminmax_i16_random_array_long::impl_i16_argminmax
CodSpeed Performance Gauge
0%
113.3 µs
113.3 µs
sse_i16_argminmax
benches/bench_i16.rs::benches::argminmax_i16_random_array_long::sse_i16_argminmax
CodSpeed Performance Gauge
0%
144.2 µs
144.2 µs
sse_i32_argminmax
benches/bench_i32.rs::benches::argminmax_i32_random_array_long::sse_i32_argminmax
CodSpeed Performance Gauge
0%
290.5 µs
290.5 µs
avx2_i8_argminmax
benches/bench_i8.rs::benches::argminmax_i8_random_array_long::avx2_i8_argminmax
CodSpeed Performance Gauge
0%
74.2 µs
74.2 µs
avx2_u16_argminmax
benches/bench_u16.rs::benches::argminmax_u16_random_array_long::avx2_u16_argminmax
CodSpeed Performance Gauge
0%
113.3 µs
113.3 µs
sse_u16_argminmax
benches/bench_u16.rs::benches::argminmax_u16_random_array_long::sse_u16_argminmax
CodSpeed Performance Gauge
0%
149.5 µs
149.5 µs
impl_u64_argminmax
benches/bench_u64.rs::benches::argminmax_u64_random_array_long::impl_u64_argminmax
CodSpeed Performance Gauge
0%
459.6 µs
459.6 µs
avx2_u64_argminmax
benches/bench_u64.rs::benches::argminmax_u64_random_array_long::avx2_u64_argminmax
CodSpeed Performance Gauge
0%
459.4 µs
459.4 µs
avx2_i64_argminmax
benches/bench_i64.rs::benches::argminmax_i64_random_array_long::avx2_i64_argminmax
CodSpeed Performance Gauge
0%
459.3 µs
459.3 µs
impl_f32_argminmax_rn
benches/bench_f32_return_nan.rs::benches::argminmax_rn_f32_random_array_long::impl_f32_argminmax_rn
CodSpeed Performance Gauge
0%
235.8 µs
235.8 µs
avx2_f32_argminmax_rn
benches/bench_f32_return_nan.rs::benches::argminmax_rn_f32_random_array_long::avx2_f32_argminmax_rn
CodSpeed Performance Gauge
0%
235.5 µs
235.5 µs
avx2_i32_argminmax
benches/bench_i32.rs::benches::argminmax_i32_random_array_long::avx2_i32_argminmax
CodSpeed Performance Gauge
0%
224.8 µs
224.8 µs
scalar_i32_argminmax
benches/bench_i32.rs::benches::argminmax_i32_random_array_long::scalar_i32_argminmax
CodSpeed Performance Gauge
0%
442.8 µs
442.8 µs
scalar_f64_argminmax_rn
benches/bench_f64_return_nan.rs::benches::argminmax_rn_f64_random_array_long::scalar_f64_argminmax_rn
CodSpeed Performance Gauge
0%
714.8 µs
714.8 µs
scalar_u8_argminmax
benches/bench_u8.rs::benches::argminmax_u8_random_array_long::scalar_u8_argminmax
CodSpeed Performance Gauge
0%
359.7 µs
359.7 µs
sse_f32_argminmax_in
benches/bench_f32_ignore_nan.rs::benches::argminmax_in_f32_random_array_long::sse_f32_argminmax_in
CodSpeed Performance Gauge
0%
276.4 µs
276.4 µs
impl_u16_argminmax
benches/bench_u16.rs::benches::argminmax_u16_random_array_long::impl_u16_argminmax
CodSpeed Performance Gauge
0%
113.4 µs
113.4 µs
scalar_f16_argminmax_rn
benches/bench_f16_return_nan.rs::benches::argminmax_rn_f16_random_array_long::scalar_f16_argminmax_rn
CodSpeed Performance Gauge
0%
634 µs
634 µs
sse_f64_argminmax_in
benches/bench_f64_ignore_nan.rs::benches::argminmax_in_f64_random_array_long::sse_f64_argminmax_in
CodSpeed Performance Gauge
0%
551.9 µs
551.9 µs
avx_f64_argminmax_in
benches/bench_f64_ignore_nan.rs::benches::argminmax_in_f64_random_array_long::avx_f64_argminmax_in
CodSpeed Performance Gauge
0%
448.9 µs
449 µs
avx_f32_argminmax_in
benches/bench_f32_ignore_nan.rs::benches::argminmax_in_f32_random_array_long::avx_f32_argminmax_in
CodSpeed Performance Gauge
0%
225 µs
225 µs
sse_f16_argminmax_rn
benches/bench_f16_return_nan.rs::benches::argminmax_rn_f16_random_array_long::sse_f16_argminmax_rn
CodSpeed Performance Gauge
0%
159.1 µs
159.2 µs
impl_f32_argminmax_in
benches/bench_f32_ignore_nan.rs::benches::argminmax_in_f32_random_array_long::impl_f32_argminmax_in
CodSpeed Performance Gauge
0%
225.1 µs
225.2 µs
impl_f16_argminmax_rn
benches/bench_f16_return_nan.rs::benches::argminmax_rn_f16_random_array_long::impl_f16_argminmax_rn
CodSpeed Performance Gauge
0%
119.5 µs
119.5 µs
avx2_f16_argminmax_rn
benches/bench_f16_return_nan.rs::benches::argminmax_rn_f16_random_array_long::avx2_f16_argminmax_rn
CodSpeed Performance Gauge
0%
119.3 µs
119.3 µs
avx2_u8_argminmax
benches/bench_u8.rs::benches::argminmax_u8_random_array_long::avx2_u8_argminmax
CodSpeed Performance Gauge
0%
73.9 µs
73.9 µs

Commits

Click on a commit to change the comparison range
Base
main
5034986
-21%
fix: allow double update in scalar ignore nan implementation
4929c9b
2 years ago
by jvdd
+15%
perf: optimize ignore nan scalar impl
56e06f1
2 years ago
by jvdd
0%
test: add test for scalar ignore nan bug
6ba2249
2 years ago
by jvdd
Home Terms PrivacyDocs