copilot/fix-export-function-deepmimo - Branch - jeertmans/DiffeRT

Implement proper EM field computation with sequential reflection handling in DeepMIMO export

#355

Comparing

copilot/fix-export-function-deepmimo

(

9189426

) with

main

(

e43a480

)

+1%

Untouched: 10

Benchmarks

Passed

test_image_method

differt/tests/benchmarks/test_rt.py

+4%

6.4 ms6.1 ms

test_compute_paths[exhaustive]

differt/tests/benchmarks/test_rt.py

+1%

45.5 ms45 ms

test_fermat

differt/tests/benchmarks/test_rt.py

+1%

123.5 ms122.5 ms

test_transmitter_visibility

differt/tests/benchmarks/test_rt.py

+1%

2.6 s2.6 s

test_first_triangles_hit_by_rays

differt/tests/benchmarks/test_rt.py

4.4 s4.4 s

test_rays_intersect_any_triangle

differt/tests/benchmarks/test_rt.py

3.2 s3.2 s

test_train_step

differt/tests/benchmarks/test_training.py

7.2 s7.2 s

test_compute_paths[hybrid]

differt/tests/benchmarks/test_rt.py

14.8 s14.8 s

test_compute_paths_disconnect_inactive_triangles_benchmark[True]

differt/tests/benchmarks/test_rt.py

30 ms30.1 ms

test_compute_paths_disconnect_inactive_triangles_benchmark[False]

differt/tests/benchmarks/test_rt.py

-1%

44 ms44.5 ms

Commits

Click on a commit to change the comparison range

Base

main

e43a480

+0.52%

Reduce test tolerances to much tighter values Changed from loose tolerances (30 degrees for phase, 5 dB for power) to much tighter ones: - Phase: atol=0.1 degrees, rtol=0.5 (50% for small values) - Power: atol=0.1 dB, rtol=0.04 (4%) These tighter tolerances use a combination of small absolute and relative tolerances to properly validate the EM field computation accuracy while accounting for both small and large values. Co-authored-by: jeertmans <27275099+jeertmans@users.noreply.github.com>

9189426

8 days ago

by Copilot

Home Terms Privacy Docs