mgorven:cancel-tasks - Branch - graphql-python/graphql-core

Cancel remaining fields on exceptions

#238Merged

Comparing

mgorven:cancel-tasks

(

2821841

) with

main

(

0107e30

)

Untouched: 14

Benchmarks

Passed

test_visit_all_ast_nodes_in_parallel

tests/benchmarks/test_visit.py

1.8 s1.8 s

test_visit_all_ast_nodes

tests/benchmarks/test_visit.py

209 ms208.8 ms

test_execute_introspection_query

tests/benchmarks/test_introspection_from_schema.py

954.4 ms954 ms

test_build_schema_from_ast

tests/benchmarks/test_build_ast_schema.py

109.6 ms109.6 ms

test_build_schema_from_introspection

tests/benchmarks/test_build_client_schema.py

126.3 ms126.3 ms

test_many_repeated_fields

tests/benchmarks/test_repeated_fields.py

272.7 ms272.6 ms

test_execute_basic_async

tests/benchmarks/test_execution_async.py

3 ms3 ms

test_validate_invalid_query

tests/benchmarks/test_validate_invalid_gql.py

186.9 ms186.9 ms

test_validate_sdl_document

tests/benchmarks/test_validate_sdl.py

447 ms447 ms

test_execute_basic_sync

tests/benchmarks/test_execution_sync.py

2.9 ms2.9 ms

test_recreate_a_graphql_schema

tests/benchmarks/test_graphql_schema.py

13.4 ms13.4 ms

test_validate_introspection_query

tests/benchmarks/test_validate_gql.py

15.4 ms15.4 ms

test_execute_async_iterable_list_field

tests/benchmarks/test_async_iterable.py

12 ms12.1 ms

test_parse_kitchen_sink

tests/benchmarks/test_parser.py

-3%

7.1 ms7.3 ms

Commits

Click on a commit to change the comparison range

Base

main

0107e30

-0.23%

Cancel remaining fields on exceptions gather() returns when the first exception is raised, but does not cancel any remaining tasks. These continue to run which is inefficient, and can also cause problems if they access shared resources like database connections. Fixes: #236

2821841

6 months ago

by mgorven

Home Terms Privacy Docs