Cancel remaining fields on exceptions
#238Comparing
mgorven:cancel-tasks
(74dae01
) withmain
(0107e30
)0%
- Improvements
- 0
- Regressions
- 0
- Untouched
- 14
- New
- 0
- Dropped
- 0
- Ignored
- 0
Benchmarks
Passed
test_build_schema_from_ast
tests/benchmarks/test_build_ast_schema.py::test_build_schema_from_ast0%
109.6 ms
109.5 ms
test_build_schema_from_introspection
tests/benchmarks/test_build_client_schema.py::test_build_schema_from_introspection0%
126.3 ms
126.2 ms
test_visit_all_ast_nodes_in_parallel
tests/benchmarks/test_visit.py::test_visit_all_ast_nodes_in_parallel0%
1.8 s
1.8 s
test_execute_introspection_query
tests/benchmarks/test_introspection_from_schema.py::test_execute_introspection_query0%
954.4 ms
954.1 ms
test_validate_invalid_query
tests/benchmarks/test_validate_invalid_gql.py::test_validate_invalid_query0%
186.9 ms
186.9 ms
test_recreate_a_graphql_schema
tests/benchmarks/test_graphql_schema.py::test_recreate_a_graphql_schema0%
13.4 ms
13.4 ms
test_validate_introspection_query
tests/benchmarks/test_validate_gql.py::test_validate_introspection_query0%
15.4 ms
15.4 ms
test_execute_basic_sync
tests/benchmarks/test_execution_sync.py::test_execute_basic_sync0%
2.9 ms
2.9 ms
test_validate_sdl_document
tests/benchmarks/test_validate_sdl.py::test_validate_sdl_document0%
447 ms
447.7 ms
test_execute_basic_async
tests/benchmarks/test_execution_async.py::test_execute_basic_async0%
3 ms
3 ms
test_many_repeated_fields
tests/benchmarks/test_repeated_fields.py::test_many_repeated_fields0%
272.7 ms
273.2 ms
test_visit_all_ast_nodes
tests/benchmarks/test_visit.py::test_visit_all_ast_nodes0%
209 ms
209.5 ms
test_execute_async_iterable_list_field
tests/benchmarks/test_async_iterable.py::test_execute_async_iterable_list_field-1%
12 ms
12.1 ms
test_parse_kitchen_sink
tests/benchmarks/test_parser.py::test_parse_kitchen_sink-2%
7.1 ms
7.2 ms
Commits
Click on a commit to change the comparison rangeBase
main
0107e30
0%
Cancel remaining fields on exceptions
gather() returns when the first exception is raised, but does not cancel
any remaining tasks. These continue to run which is inefficient, and can
also cause problems if they access shared resources like database
connections.
Fixes: #236
74dae01
1 day ago
by mgorven