corydolphin:make-visitor-immutable-friendly - Branch - graphql-python/graphql-core

4: Make visitor immutable friendly

#253Merged

Comparing

corydolphin:make-visitor-immutable-friendly

(

c63ef1d

) with

main

(

283d002

)

Untouched: 14

New: 4

Benchmarks

New

test_pickle_large_query_decode

tests/benchmarks/test_serialization.py

N/A

N/A207.8 ms

test_parse_large_query

tests/benchmarks/test_serialization.py

N/A

N/A421.4 ms

test_pickle_large_query_roundtrip

tests/benchmarks/test_serialization.py

N/A

N/A317.3 ms

test_pickle_large_query_encode

tests/benchmarks/test_serialization.py

N/A

N/A109.8 ms

Passed

test_visit_all_ast_nodes_in_parallel

tests/benchmarks/test_visit.py

1.6 s1.6 s

test_execute_async_iterable_list_field

tests/benchmarks/test_async_iterable.py

13.4 ms13.4 ms

test_many_repeated_fields

tests/benchmarks/test_repeated_fields.py

265.2 ms265.1 ms

test_build_schema_from_ast

tests/benchmarks/test_build_ast_schema.py

104.6 ms104.6 ms

test_validate_sdl_document

tests/benchmarks/test_validate_sdl.py

426.2 ms426.1 ms

test_execute_basic_sync

tests/benchmarks/test_execution_sync.py

2.6 ms2.6 ms

test_visit_all_ast_nodes

tests/benchmarks/test_visit.py

200.9 ms201 ms

test_validate_invalid_query

tests/benchmarks/test_validate_invalid_gql.py

99.7 ms99.8 ms

test_execute_introspection_query

tests/benchmarks/test_introspection_from_schema.py

915 ms915.8 ms

test_build_schema_from_introspection

tests/benchmarks/test_build_client_schema.py

115.8 ms115.9 ms

test_validate_introspection_query

tests/benchmarks/test_validate_gql.py

15 ms15 ms

test_execute_basic_async

tests/benchmarks/test_execution_async.py

2.7 ms2.7 ms

test_recreate_a_graphql_schema

tests/benchmarks/test_graphql_schema.py

12.7 ms12.8 ms

test_parse_kitchen_sink

tests/benchmarks/test_parser.py

6.8 ms6.8 ms

Commits

Click on a commit to change the comparison range

Base

main

283d002

-0.07%

Make visitor immutable-friendly Modifies the AST visitor to use copy-on-write semantics when applying edits. Instead of mutating nodes in place, the visitor now creates new node instances with the edited values. This prepares for frozen AST nodes while maintaining backwards compatibility. The visitor accumulates edits and applies them by constructing new nodes, enabling the transition to immutable data structures.

c63ef1d

4 days ago

by corydolphin

Home Terms Privacy Docs