Avatar for the esphome user
esphome
aioesphomeapi
BlogDocsChangelog

Ensure third party callbacks on BLE notify do not cause disconnect

#1212Merged
Comparing
prevent_3rdparty_disconnect_notify
(
102e4ba
) with
main
(
782a429
)
CodSpeed Performance Gauge
0%
Improvements
0
Regressions
0
Untouched
11
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

test_multiple_ble_adv_messages_single_read
tests/benchmarks/test_bluetooth.py::test_multiple_ble_adv_messages_single_read
CodSpeed Performance Gauge
+1%
28.2 µs
27.9 µs
test_noise_messages[1024]
tests/benchmarks/test_noise.py::test_noise_messages[1024]
CodSpeed Performance Gauge
0%
1.9 ms
1.9 ms
test_raw_ble_plain_text_with_callback
tests/benchmarks/test_bluetooth.py::test_raw_ble_plain_text_with_callback
CodSpeed Performance Gauge
0%
37.9 µs
37.8 µs
test_noise_messages[0]
tests/benchmarks/test_noise.py::test_noise_messages[0]
CodSpeed Performance Gauge
0%
1.3 ms
1.3 ms
test_sending_empty_light_command_request
tests/benchmarks/test_requests.py::test_sending_empty_light_command_request
CodSpeed Performance Gauge
0%
42.2 µs
42.1 µs
test_raw_ble_plain_text_different_advs
tests/benchmarks/test_bluetooth.py::test_raw_ble_plain_text_different_advs
CodSpeed Performance Gauge
0%
20.4 µs
20.4 µs
test_noise_messages[128]
tests/benchmarks/test_noise.py::test_noise_messages[128]
CodSpeed Performance Gauge
0%
1.5 ms
1.5 ms
test_noise_messages[64]
tests/benchmarks/test_noise.py::test_noise_messages[64]
CodSpeed Performance Gauge
0%
1.4 ms
1.4 ms
test_sending_light_command_request_with_bool
tests/benchmarks/test_requests.py::test_sending_light_command_request_with_bool
CodSpeed Performance Gauge
0%
45.8 µs
45.8 µs
test_noise_messages[16384]
tests/benchmarks/test_noise.py::test_noise_messages[16384]
CodSpeed Performance Gauge
0%
15 ms
15 ms
test_raw_ble_plain_text
tests/benchmarks/test_bluetooth.py::test_raw_ble_plain_text
CodSpeed Performance Gauge
0%
22.5 µs
22.5 µs

Commits

Click on a commit to change the comparison range
Base
main
782a429
0%
Ensure third party callbacks on BLE notify do not cause disconnect We need a broad exception catch around the callback since it calls back into third party code which may raise up to the protocol handler and disconnect the device.
102e4ba
22 days ago
by bdraco
© 2025 CodSpeed Technology
Home Terms Privacy Docs