better-error-messages - Branch - egraphs-good/egglog-python

Improve error messages when using non classvar type annotation

#121Merged

Comparing

better-error-messages

(

020345f

) with

main

(

e25523c

)

-1%

Untouched: 7

Benchmarks

Passed

test_execution[array_api-optimized-numba]

python/tests/test_array_api.py::TestLDA

+1%

240.6 µs239 µs

test_execution[array_api-optimized]

python/tests/test_array_api.py::TestLDA

836.8 µs834.7 µs

test_trace

python/tests/test_array_api.py::TestLDA

1.5 s1.5 s

test_optimize

python/tests/test_array_api.py::TestLDA

-1%

1.5 s1.5 s

test_execution[array_api]

python/tests/test_array_api.py::TestLDA

-1%

3.4 ms3.5 ms

test_execution[base]

python/tests/test_array_api.py::TestLDA

-1%

1.9 ms1.9 ms

test_source_optimized

python/tests/test_array_api.py::TestLDA

-3%

8.9 s9.2 s

Commits

Click on a commit to change the comparison range

Base

main

e25523c

-0.82%

Improve error messages when using non classvar type annotation Previously, if you did something like `x: str` in a classbody there would be an odd error, since it wouldn't be able to resolve the `__egg_decls__`. This fixes it to be more descriptive. See https://egraphs.zulipchat.com/#narrow/stream/375765-egg.2Fegglog/topic/First.20time.20user.20of.20python.20bindings/near/421756317

020345f

2 years ago

by saulshanabrook

Home Terms Privacy Docs