Avatar for the egraphs-good user
egraphs-good
egglog-python
BlogDocsChangelog

Improve error messages when using non classvar type annotation

#121Merged
Comparing
better-error-messages
(
020345f
) with
main
(
e25523c
)
CodSpeed Performance Gauge
-1%
Improvements
0
Regressions
0
Untouched
7
New
0
Dropped
0
Ignored
0

Benchmarks

Passed

test_execution[array_api-optimized-numba]
python/tests/test_array_api.py::TestLDA::test_execution[array_api-optimized-numba]
CodSpeed Performance Gauge
+1%
240.6 µs
239 µs
test_execution[array_api-optimized]
python/tests/test_array_api.py::TestLDA::test_execution[array_api-optimized]
CodSpeed Performance Gauge
0%
836.8 µs
834.7 µs
test_trace
python/tests/test_array_api.py::TestLDA::test_trace
CodSpeed Performance Gauge
0%
1.5 s
1.5 s
test_optimize
python/tests/test_array_api.py::TestLDA::test_optimize
CodSpeed Performance Gauge
-1%
1.5 s
1.5 s
test_execution[array_api]
python/tests/test_array_api.py::TestLDA::test_execution[array_api]
CodSpeed Performance Gauge
-1%
3.4 ms
3.5 ms
test_execution[base]
python/tests/test_array_api.py::TestLDA::test_execution[base]
CodSpeed Performance Gauge
-1%
1.9 ms
1.9 ms
test_source_optimized
python/tests/test_array_api.py::TestLDA::test_source_optimized
CodSpeed Performance Gauge
-3%
8.9 s
9.2 s

Commits

Click on a commit to change the comparison range
Base
main
e25523c
-1%
Improve error messages when using non classvar type annotation Previously, if you did something like `x: str` in a classbody there would be an odd error, since it wouldn't be able to resolve the `__egg_decls__`. This fixes it to be more descriptive. See https://egraphs.zulipchat.com/#narrow/stream/375765-egg.2Fegglog/topic/First.20time.20user.20of.20python.20bindings/near/421756317
020345f
1 year ago
by saulshanabrook
Home Terms PrivacyDocs