ok-nick/cyclic-ingredients - Branch - contentauth/c2pa-rs

fix: stack overflow and hang due to cyclic ingredients

#1576

Comparing

ok-nick/cyclic-ingredients

(

f5e534c

) with

main

(

5775d4f

)

Untouched: 16

Skipped: 2

Benchmarks

Skipped (2)

Passed

read 100kb-signed.jpg (with manifest)

sdk/benches/read.rs::benches::read_jpeg

+2%

12 ms11.8 ms

sign 100kb png

sdk/benches/sign.rs::benches::sign_png

+2%

6 ms5.9 ms

read 100kb-signed.wav (with manifest)

sdk/benches/read.rs::benches::read_wav

+1%

4.7 ms4.7 ms

sign 100kb mp4

sdk/benches/sign.rs::benches::sign_mp4

+1%

5.8 ms5.7 ms

read 100kb-signed.svg (with manifest)

sdk/benches/read.rs::benches::read_svg

8.6 ms8.6 ms

sign 100kb svg

sdk/benches/sign.rs::benches::sign_svg

17.4 ms17.4 ms

sign 100kb mp3

sdk/benches/sign.rs::benches::sign_mp3

4.6 ms4.6 ms

read 100kb-signed.mp4 (with manifest)

sdk/benches/read.rs::benches::read_mp4

4.8 ms4.8 ms

read 100kb-signed.png (with manifest)

sdk/benches/read.rs::benches::read_png

12.1 ms12.1 ms

read 100kb-signed.gif (with manifest)

sdk/benches/read.rs::benches::read_gif

4.6 ms4.6 ms

read 100kb-signed.tiff (with manifest)

sdk/benches/read.rs::benches::read_tiff

2.7 ms2.7 ms

read 100kb-signed.mp3 (with manifest)

sdk/benches/read.rs::benches::read_mp3

5 ms5 ms

sign 100kb wav

sdk/benches/sign.rs::benches::sign_wav

4.9 ms4.9 ms

sign 100kb tiff

sdk/benches/sign.rs::benches::sign_tiff

2.1 ms2.1 ms

sign 100kb gif

sdk/benches/sign.rs::benches::sign_gif

-1%

3.9 ms4 ms

sign 100kb jpeg

sdk/benches/sign.rs::benches::sign_jpeg

-3%

5.3 ms5.5 ms

Commits

Click on a commit to change the comparison range

Base

main

5775d4f

-0.23%

fix: clean up seen logic

3f1e924

20 days ago

by ok-nick

+0.12%

test: fix add hash mismatch check and non-pre-validating CAWG check

a2121d4

19 days ago

by ok-nick

-0.23%

style: fix clippy lints

946b6fd

19 days ago

by ok-nick

+0.26%

fix: simplify seen recursive ingredient checks

1c7bb7c

16 days ago

by ok-nick

+0.06%

chore: remove test file

57784ab

16 days ago

by ok-nick

+0.66%

fix: detect cyclic ingredients and report Error::CyclicIngredients with path

6710e14

16 days ago

by ok-nick

-0.92%

fix: return log error instead of hard error for cyclic ingredients

d4d6791

16 days ago

by ok-nick

+0.38%

fix: hard error if cyclic ingredient is found

f5e534c

16 days ago

by ok-nick

Home Terms Privacy Docs