fix-double-adding-of-the-same-related - Branch - collerek/ormar

fix index error on double addition of the same related model

#1346Merged

Comparing

fix-double-adding-of-the-same-related

(

1871aca

) with

master

(

ef705cc

)

Improvements: 0

Regressions: 0

Untouched: 84

New: 0

Dropped: 0

Ignored: 0

Benchmarks

Passed

test_get_all_with_related_models[10]

benchmarks/test_benchmark_get.py::test_get_all_with_related_models[10]

+1%

14.1 ms

13.9 ms

test_max[250]

benchmarks/test_benchmark_aggregate.py::test_max[250]

+1%

3.7 ms

3.6 ms

test_deleting_all[500]

benchmarks/test_benchmark_delete.py::test_deleting_all[500]

+1%

3 ms

2.9 ms

test_values_list[250]

benchmarks/test_benchmark_values.py::test_values_list[250]

+1%

8 ms

test_values_list[500]

benchmarks/test_benchmark_values.py::test_values_list[500]

+1%

12.2 ms

12.1 ms

test_deleting_all[250]

benchmarks/test_benchmark_delete.py::test_deleting_all[250]

+1%

1.9 ms

test_saving_models_individually[10]

benchmarks/test_benchmark_save.py::test_saving_models_individually[10]

+1%

14.6 ms

14.5 ms

test_creating_models_individually[10]

benchmarks/test_benchmark_create.py::test_creating_models_individually[10]

+1%

12.3 ms

12.2 ms

test_iterate[500]

benchmarks/test_benchmark_iterate.py::test_iterate[500]

+1%

80.5 ms

80 ms

test_get_one[500]

benchmarks/test_benchmark_get.py::test_get_one[500]

+1%

3.1 ms

test_get_or_none[500]

benchmarks/test_benchmark_get.py::test_get_or_none[500]

+1%

3.2 ms

3.1 ms

test_get_or_create_when_get[500]

benchmarks/test_benchmark_get.py::test_get_or_create_when_get[500]

+1%

3.2 ms

test_get_or_none[1000]

benchmarks/test_benchmark_get.py::test_get_or_none[1000]

+1%

4.2 ms

4.1 ms

test_updating_models_individually[40]

benchmarks/test_benchmark_update.py::test_updating_models_individually[40]

+1%

42.9 ms

42.7 ms

test_get_or_create_when_get[250]

benchmarks/test_benchmark_get.py::test_get_or_create_when_get[250]

3.6 ms

test_min[1000]

benchmarks/test_benchmark_aggregate.py::test_min[1000]

4.4 ms

test_count[500]

benchmarks/test_benchmark_aggregate.py::test_count[500]

4.4 ms

4.3 ms

test_updating_models_individually[20]

benchmarks/test_benchmark_update.py::test_updating_models_individually[20]

21.9 ms

21.8 ms

test_iterate[1000]

benchmarks/test_benchmark_iterate.py::test_iterate[1000]

158.5 ms

157.8 ms

test_get_or_create_when_create[40]

benchmarks/test_benchmark_create.py::test_get_or_create_when_create[40]

99.3 ms

98.9 ms

test_sum[500]

benchmarks/test_benchmark_aggregate.py::test_sum[500]

3.3 ms

3.2 ms

test_exists[500]

benchmarks/test_benchmark_get.py::test_exists[500]

3.2 ms

test_saving_models_individually_with_related_models[20]

benchmarks/test_benchmark_save.py::test_saving_models_individually_with_related_models[20]

31.7 ms

31.6 ms

test_iterate[250]

benchmarks/test_benchmark_iterate.py::test_iterate[250]

41.2 ms

41.1 ms

test_get_all_with_related_models[20]

benchmarks/test_benchmark_get.py::test_get_all_with_related_models[20]

20.1 ms

20 ms

test_saving_models_individually[20]

benchmarks/test_benchmark_save.py::test_saving_models_individually[20]

23.3 ms

23.2 ms

test_get_or_create_when_create[20]

benchmarks/test_benchmark_create.py::test_get_or_create_when_create[20]

50.1 ms

50 ms

test_min[250]

benchmarks/test_benchmark_aggregate.py::test_min[250]

3.7 ms

3.6 ms

test_updating_models_in_bulk[40]

benchmarks/test_benchmark_bulk_update.py::test_updating_models_in_bulk[40]

19.1 ms

19 ms

test_get_one[1000]

benchmarks/test_benchmark_get.py::test_get_one[1000]

4.2 ms

test_updating_models_individually[10]

benchmarks/test_benchmark_update.py::test_updating_models_individually[10]

11.3 ms

test_first[250]

benchmarks/test_benchmark_get.py::test_first[250]

3.5 ms

test_creating_individually_with_related_models[10]

benchmarks/test_benchmark_create.py::test_creating_individually_with_related_models[10]

15.8 ms

test_exists[250]

benchmarks/test_benchmark_get.py::test_exists[250]

3.7 ms

test_update_or_create_when_create[20]

benchmarks/test_benchmark_create.py::test_update_or_create_when_create[20]

23.4 ms

test_values[1000]

benchmarks/test_benchmark_values.py::test_values[1000]

21.7 ms

test_initializing_models_with_related_models[40]

benchmarks/test_benchmark_init.py::test_initializing_models_with_related_models[40]

16.9 ms

test_saving_models_individually_with_related_models[40]

benchmarks/test_benchmark_save.py::test_saving_models_individually_with_related_models[40]

68 ms

67.9 ms

test_max[500]

benchmarks/test_benchmark_aggregate.py::test_max[500]

3.3 ms

test_initializing_models_with_related_models[20]

benchmarks/test_benchmark_init.py::test_initializing_models_with_related_models[20]

5.9 ms

test_updating_models_in_bulk[10]

benchmarks/test_benchmark_bulk_update.py::test_updating_models_in_bulk[10]

6.2 ms

6.1 ms

test_creating_models_individually[40]

benchmarks/test_benchmark_create.py::test_creating_models_individually[40]

45.8 ms

test_get_or_create_when_create[10]

benchmarks/test_benchmark_create.py::test_get_or_create_when_create[10]

25.8 ms

test_get_all_with_related_models[40]

benchmarks/test_benchmark_get.py::test_get_all_with_related_models[40]

41.8 ms

test_saving_models_individually_with_related_models[10]

benchmarks/test_benchmark_save.py::test_saving_models_individually_with_related_models[10]

15.5 ms

test_get_one[250]

benchmarks/test_benchmark_get.py::test_get_one[250]

2.5 ms

test_update_or_create_when_create[40]

benchmarks/test_benchmark_create.py::test_update_or_create_when_create[40]

45.9 ms

test_get_or_create_when_get[1000]

benchmarks/test_benchmark_get.py::test_get_or_create_when_get[1000]

4.2 ms

test_sum[250]

benchmarks/test_benchmark_aggregate.py::test_sum[250]

3.6 ms

test_creating_individually_with_related_models[40]

benchmarks/test_benchmark_create.py::test_creating_individually_with_related_models[40]

65.3 ms

test_creating_models_individually[20]

benchmarks/test_benchmark_create.py::test_creating_models_individually[20]

23.3 ms

test_avg[1000]

benchmarks/test_benchmark_aggregate.py::test_avg[1000]

4.4 ms

test_values_list[1000]

benchmarks/test_benchmark_values.py::test_values_list[1000]

22.5 ms

test_saving_models_individually[40]

benchmarks/test_benchmark_save.py::test_saving_models_individually[40]

45.5 ms

test_creating_individually_with_related_models[20]

benchmarks/test_benchmark_create.py::test_creating_individually_with_related_models[20]

31.2 ms

test_updating_models_in_bulk[20]

benchmarks/test_benchmark_bulk_update.py::test_updating_models_in_bulk[20]

10.3 ms

test_get_or_none[250]

benchmarks/test_benchmark_get.py::test_get_or_none[250]

3.6 ms

test_min[500]

benchmarks/test_benchmark_aggregate.py::test_min[500]

3.3 ms

test_first[1000]

benchmarks/test_benchmark_get.py::test_first[1000]

4.1 ms

test_values[250]

benchmarks/test_benchmark_values.py::test_values[250]

6.7 ms

test_update_or_create_when_create[10]

benchmarks/test_benchmark_create.py::test_update_or_create_when_create[10]

12.1 ms

test_get_all[1000]

benchmarks/test_benchmark_get.py::test_get_all[1000]

148.1 ms

148.3 ms

test_values[500]

benchmarks/test_benchmark_values.py::test_values[500]

11.7 ms

test_get_all[250]

benchmarks/test_benchmark_get.py::test_get_all[250]

38.5 ms

test_deleting_individually[20]

benchmarks/test_benchmark_delete.py::test_deleting_individually[20]

16.3 ms

16.4 ms

test_max[1000]

benchmarks/test_benchmark_aggregate.py::test_max[1000]

4.4 ms

test_making_and_inserting_models_in_bulk[40]

benchmarks/test_benchmark_bulk_create.py::test_making_and_inserting_models_in_bulk[40]

10.4 ms

test_get_all[500]

benchmarks/test_benchmark_get.py::test_get_all[500]

74.5 ms

74.7 ms

test_deleting_all[1000]

benchmarks/test_benchmark_delete.py::test_deleting_all[1000]

4.5 ms

4.6 ms

test_avg[250]

benchmarks/test_benchmark_aggregate.py::test_avg[250]

3.7 ms

test_deleting_individually[40]

benchmarks/test_benchmark_delete.py::test_deleting_individually[40]

32 ms

32.1 ms

test_making_and_inserting_models_in_bulk[20]

benchmarks/test_benchmark_bulk_create.py::test_making_and_inserting_models_in_bulk[20]

5.8 ms

test_count[1000]

benchmarks/test_benchmark_aggregate.py::test_count[1000]

5.9 ms

6 ms

test_sum[1000]

benchmarks/test_benchmark_aggregate.py::test_sum[1000]

4.4 ms

test_exists[1000]

benchmarks/test_benchmark_get.py::test_exists[1000]

4.2 ms

test_deleting_individually[10]

benchmarks/test_benchmark_delete.py::test_deleting_individually[10]

-1%

9.8 ms

9.9 ms

test_first[500]

benchmarks/test_benchmark_get.py::test_first[500]

-1%

3.1 ms

test_making_and_inserting_models_in_bulk[10]

benchmarks/test_benchmark_bulk_create.py::test_making_and_inserting_models_in_bulk[10]

-1%

4.9 ms

5 ms

test_count[250]

benchmarks/test_benchmark_aggregate.py::test_count[250]

-1%

3.8 ms

3.9 ms

test_initializing_models_with_related_models[10]

benchmarks/test_benchmark_init.py::test_initializing_models_with_related_models[10]

-1%

2.4 ms

test_avg[500]

benchmarks/test_benchmark_aggregate.py::test_avg[500]

-1%

3.3 ms

test_initializing_models[250]

benchmarks/test_benchmark_init.py::test_initializing_models[250]

-1%

18.5 ms

18.6 ms

test_initializing_models[500]

benchmarks/test_benchmark_init.py::test_initializing_models[500]

-1%

33.9 ms

34.3 ms

test_initializing_models[1000]

benchmarks/test_benchmark_init.py::test_initializing_models[1000]

-1%

67.3 ms

68.1 ms

Commits

Click on a commit to change the comparison range

Base

master

ef705cc

+35%

fix index error on double addition of the same related model

a80be39

8 months ago

by collerek

-12%

connect to db

39f6eeb

8 months ago

by collerek

-23%

change to cleanup instead of transaction as a check

1871aca

8 months ago

by collerek

Home Terms Privacy Docs